Skip to content

Improve tcpdump support + integ test #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 13, 2023
Merged

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Dec 8, 2023

Issues:

N/A

Description of changes:

  • Improves AWS-LC support for tcpdump.
  • Adds tcpdump integration test to our CI.

Call-outs:

  • Patch required for tcpdump's configure script so that it recognizes AWS-LC as valid.

Testing:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner December 8, 2023 16:42
@justsmth justsmth force-pushed the tcpdump-integ branch 2 times, most recently from d5b8528 to 2b60f79 Compare December 8, 2023 16:45
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (95cc2ce) 76.76% compared to head (1ad7627) 76.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1351   +/-   ##
=======================================
  Coverage   76.76%   76.77%           
=======================================
  Files         422      422           
  Lines       71190    71199    +9     
=======================================
+ Hits        54651    54660    +9     
  Misses      16539    16539           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

torben-hansen
torben-hansen previously approved these changes Dec 8, 2023
@justsmth justsmth merged commit ac1b59a into aws:main Dec 13, 2023
@justsmth justsmth deleted the tcpdump-integ branch December 13, 2023 21:57
@skmcgrail skmcgrail mentioned this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants