Skip to content

Adding unprocessedKeysForTable to BatchGetItem results object #2425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2021

Conversation

bmaizels
Copy link
Contributor

Description

DynamoDB returns keys that could not be processed in a BatchGetItem result, however there was no way to get at these values
through the enhanced client. Inferring which keys were not processed by subtracting the results list from the inputs was not
sufficient because if any of the items were missing from the results, it would be impossible to know if they were not included in
the result set because they were not processed or if they were actually missing.

Motivation and Context

At least one customer has asked for this functionality. DynamoDbMapper provides this functionality by throwing an exception and providing the partial results and the unprocessed keys in that exception, so this is also a feature parity issue.

Testing

Unit tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@bmaizels bmaizels requested a review from zoewangg April 20, 2021 00:59
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@zoewangg zoewangg merged commit cba776c into master Apr 20, 2021
@zoewangg zoewangg deleted the bmaizels/ddbenhanced-batchget-unprocessedkeys branch April 20, 2021 21:56
aws-sdk-java-automation added a commit that referenced this pull request Mar 21, 2023
…0fb4c6f9e

Pull request: release <- staging/e5aa3891-ac98-48e3-97e8-a6b0fb4c6f9e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants