Add additional backwards-compatibility testing for legacy clients. #4493
Conversation
millems
commented
Sep 27, 2023
millems
commented
- Ensure anonymous credentials function correctly
- Ensure attributes set in custom execution interceptors make it to the legacy signer
1. Ensure anonymous credentials function correctly 2. Ensure attributes set in custom execution interceptors make it to the legacy signer
| T currentValue = get(attributes); | ||
| if (currentValue == null) { | ||
| set(attributes, value); | ||
| } |
There was a problem hiding this comment.
This is more correct, since the presence of the real attribute does not necessarily indicate that the execution attribute value is present (e.g. a signer property's existence isn't guaranteed even if the selected auth scheme is present).
There was a problem hiding this comment.
This fixed issues we've identified in other testing, even with new clients, since we still have code in core that does putIfAbsent after auth scheme is selected. Thank you!
| import software.amazon.awssdk.testutils.service.http.MockSyncHttpClient; | ||
|
|
||
| /** | ||
| * Ensure that attributes set in execution interceptors are passed to custom signers. |
There was a problem hiding this comment.
nit: can you add a note here saying the attributes being tested here are SdkProtectedApi, but we still want to make sure if works if customer set these via interceptors.
…-compatible-testing-2
…-compatible-testing-2
|
SonarCloud Quality Gate failed.
|
