Skip to content

Remove CodeCatalystIntegration test #4502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

millems
Copy link
Contributor

@millems millems commented Sep 28, 2023

It's not possible to automatically test bearer token support for this service, because it requires a user to be present. Updated the test to mock out the service.

It's not possible to automatically test bearer token support for this service, because it requires a user to be present. Updated the test to mock out the service.
@millems millems requested a review from a team as a code owner September 28, 2023 19:54
Copy link
Contributor

@gosar gosar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I added that test as part of my local testing for initial auth scheme resolver integration. Didn't know of a better way, and needed some test. This is nicer.

@millems millems merged commit 8de2748 into feature/master/sra-identity-auth Sep 28, 2023
@millems millems deleted the millem/codecatalyst-integration-test-fix branch September 28, 2023 21:25
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 4 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 465 Code Smells

84.2% 84.2% Coverage
4.0% 4.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@gosar gosar mentioned this pull request Oct 3, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants