Skip to content

Migration tool - S3 transforms #6014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

Migration tool - S3 transforms #6014

merged 1 commit into from
Apr 9, 2025

Conversation

davidh44
Copy link
Contributor

@davidh44 davidh44 commented Apr 8, 2025

Motivation and Context

Additional transforms for S3

Methods:

setBucketVersioningConfiguration()
restoreObjectV2()
getObject(GetObjectRequest getObjectRequest, File destinationFile)
getRegionName()

Pojos

SetBucketLoggingConfigurationRequest
SetBucketVersioningConfigurationRequest
SetBucketNotificationConfigurationRequest
SetRequestPaymentConfigurationRequest
BucketVersioningConfiguration
Owner
PartitionedPrefix
RestoreObjectRequest
SetBucketPolicyRequest
GetObjectTaggingResult
GetObjectRequest(String bucketName, String key, boolean isRequesterPays) 
DeleteVersionRequest(String bucketName, String key, String versionId, MultiFactorAuthentication mfa) - MultiFactorAuthentication POJO to String transform not supported

Testing

Added end to end tests

@davidh44 davidh44 requested a review from a team as a code owner April 8, 2025 00:00
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 8, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

zoewangg
zoewangg approved these changes Apr 8, 2025
View reviewed changes
...amazon/awssdk/v2migrationtests/maven-nocompile/after/src/main/java/foo/bar/S3Transforms.java
@@ -33,6 +35,12 @@

public class S3Transforms {

void s3Pojos() {
DeleteObjectRequest deleteVersionRequest =
DeleteObjectRequest.builder().bucket("bucket").key("key").versionId("id").mfa(new MultiFactorAuthentication("serialNum", "token"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a comment to show how customers can fix it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will do as follow up. Want to merge these changes to include in the benchmarks

@davidh44 davidh44 added this pull request to the merge queue Apr 8, 2025
Merged via the queue into master with commit 5052321 Apr 9, 2025
25 of 27 checks passed
@davidh44 davidh44 deleted the hdavidh/migration-tool-s3-transforms branch April 9, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoewangg zoewangg zoewangg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidh44 @zoewangg