Add retry tests for request bodies #6056
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds tests for implementations of `RequestBody` and `AsyncRequestBody` where the requests are retried to ensure that they send the same content for every attempt.
Fred1155
reviewed
Apr 25, 2025
test/s3-tests/src/test/java/software/amazon/awssdk/services/s3/BaseRequestBodyRetryTest.java
Show resolved
Hide resolved
Fred1155
approved these changes
Apr 29, 2025
RanVaknin
approved these changes
Apr 29, 2025
Unfortunately WireMock saves all the request bodies which increases memory usage. Use a plain Jetty server that doesn't save requests to avoid this. We don't rely on any WireWock request assertions so it works out.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds tests for implementations of
RequestBodyandAsyncRequestBodywhere the requests are retried to ensure that they send the same content for every attempt.Motivation and Context
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License