-
Notifications
You must be signed in to change notification settings - Fork 904
Added support for s3-event-notifications in migration tool #6059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+446
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagnir
reviewed
Apr 30, 2025
...on/awssdk/v2migrationtests/maven-en/after/src/main/java/foo/bar/S3EventNotificationTest.java
Outdated
Show resolved
Hide resolved
davidh44
reviewed
Apr 30, 2025
v2-migration/src/main/resources/META-INF/rewrite/aws-sdk-java-v1-to-v2.yml
Show resolved
Hide resolved
davidh44
reviewed
Apr 30, 2025
...ests/src/test/java/software/amazon/awssdk/v2migrationtests/MavenS3EventNotificationTest.java
Outdated
Show resolved
Hide resolved
|
dagnir
approved these changes
May 1, 2025
davidh44
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR added support for s3-event-notifications in migration tool. s3-event-notifications is a separate module in v2, while in v1 it is in s3.event folder. All nested class in S3EventNotification class in v1 is a separated class in v2.
Modifications
Added transform for all package names.
Added transform for all different method names.
Added transform for different return types (getEventNameAsEnum() and getEventTime())
Added recipe to add wrapper for methods that return DateTime in v1 and Instant in v2
Testing
Added new integration test class for s3-event-notifications module
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License