Skip to content

Added support for s3-event-notifications in migration tool #6059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
May 2, 2025

Conversation

Fred1155
Copy link
Contributor

@Fred1155 Fred1155 commented Apr 24, 2025

Motivation and Context

This PR added support for s3-event-notifications in migration tool. s3-event-notifications is a separate module in v2, while in v1 it is in s3.event folder. All nested class in S3EventNotification class in v1 is a separated class in v2.

Modifications

Added transform for all package names.
Added transform for all different method names.
Added transform for different return types (getEventNameAsEnum() and getEventTime())
Added recipe to add wrapper for methods that return DateTime in v1 and Instant in v2

Testing

Added new integration test class for s3-event-notifications module

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@Fred1155 Fred1155 requested a review from a team as a code owner April 24, 2025 23:44
Copy link

sonarqubecloud bot commented May 1, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
7.4% Coverage on New Code (required ≥ 80%)
18.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@Fred1155 Fred1155 enabled auto-merge May 1, 2025 21:19
@Fred1155 Fred1155 added this pull request to the merge queue May 1, 2025
Merged via the queue into master with commit d4da845 May 2, 2025
32 of 35 checks passed
@Fred1155 Fred1155 deleted the bole/s3-event-notification-migration branch May 2, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants