Bump OpenRewrite to 3.6.1 #6072
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
reviewed
Apr 29, 2025
Comment on lines
34
to
35
| @Disabled("With OpenRewrite version bump, unit tests fail when ExecutionContext#putMessage is used with multiple recipes " | ||
| + "(invoked in HttpSettingsToHttpClient)") |
There was a problem hiding this comment.
You don't have to disable the entire test; you can disable that particular validation step instead through TypeValidation:
https://github.com/openrewrite/rewrite/blob/e84018e2dfc38578eb6c7d5930b6c04002f18627/rewrite-test/src/main/java/org/openrewrite/test/TypeValidation.java#L113-L118
There was a problem hiding this comment.
Worked, thanks Tim!
Fred1155
reviewed
Apr 29, 2025
v2-migration/src/test/java/software/amazon/awssdk/v2migration/ChangeConfigTypesTest.java
Show resolved
Hide resolved
|
zoewangg
approved these changes
Apr 29, 2025
Fred1155
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Continuation of #6040 to bump
rewrite-recipe-bomto3.6.1(OpenRewrite v8.50.2)Cannot bump to to latest
3.7.0asJavaType.Methodconstructors were dropped, requires further refactoring in SDK recipesModifications
ChangeMethodInvocationReturnTypeand use OpenRewrite oneLto content length arg inRequestBody.fromInputStream()as it is not necessary and breaks with the version bumprewrite-maven-plugin6.6.0rewrite-gradle-plugin7.4.1Testing
Ran end to end tests