Skip to content

chore(clients): populate default values for auth scheme preference #7038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 29, 2025

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Apr 28, 2025

Issue

Internal JS-5811

Description

Populates default values for auth scheme preference

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as ready for review April 28, 2025 20:32
@trivikr trivikr requested a review from a team as a code owner April 28, 2025 20:32
@trivikr trivikr merged commit 093005b into main Apr 29, 2025
2 checks passed
@@ -2,7 +2,7 @@
// @ts-ignore: package.json will be imported from dist folders
import packageInfo from "../package.json"; // eslint-disable-line

import { emitWarningIfUnsupportedVersion as awsCheckVersion } from "@aws-sdk/core";
import { NODE_AUTH_SCHEME_PREFERENCE_OPTIONS, emitWarningIfUnsupportedVersion as awsCheckVersion } from "@aws-sdk/core";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NODE_AUTH_SCHEME_PREFERENCE_OPTIONS should be imported from @aws-sdk/core/httpAuthSchemes to eventually move away from importing anything from the root index of core.

@trivikr trivikr deleted the populate-auth-scheme-preference branch May 8, 2025 15:17
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants