Optimize AWS4Signer #3324
Merged
Optimize AWS4Signer #3324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@normj I would appreciate your input ;) |
normj
requested changes
May 26, 2024
sdk/src/Core/Amazon.Runtime/Internal/Util/ValueStringBuilder.cs
Outdated
Show resolved
Hide resolved
Dreamescaper
reviewed
Jun 6, 2024
…ed in the majority of the cases and benefits from .NET improvements
danielmarbach
force-pushed
the
valuestringbuilder
branch
from
6d9d80a to
984f278
Compare
|
@normj I have to update the description of the PR but I'm running out of my fun coding time allotted budget for now. I have added some benchmark results that should speak though themselves. Of course ideally it would be better if we could bring the ValueStringBuilder ref struct into the helper methods but since I did not get feedback on the usage of those protected static methods I went ahead and used an approach that doesn't require signature changes which I think is in your favor anyway for now. @Dreamescaper I also addressed one of your feedbacks |
danielmarbach
changed the title
danielmarbach
commented
Jun 28, 2024
| } | ||
|
|
||
| return builder.ToString(); | ||
| return string.Join(";", sortedHeaders.Select(x => x.Key.ToLowerInvariant())); |
There was a problem hiding this comment.
Ran another benchmark on Fedora and decided to switch to ValueStringBuilder here too
peterrsongg
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR heavily optimizes the HTTP header path on the AWS4Signer to reduce the number of allocations.
Description
See screenshots
Motivation and Context
Making sure the request path is less allocation heavy will drastically improve the throughput of the AWS SDK.
Testing
Screenshots (if appropriate)
CanonicalHeaderNames
https://github.com/danielmarbach/aws-sdk-net-benchmarks/blob/main/CanonicalHeaderNames.cs
CanonicalHeaders
https://github.com/danielmarbach/aws-sdk-net-benchmarks/blob/main/CanonicalHeaderNames.cs
CompressSpace
https://github.com/danielmarbach/aws-sdk-net-benchmarks/blob/main/CompressSpace.cs
CanonicalHeaders with CompressSpace
https://github.com/danielmarbach/aws-sdk-net-benchmarks/blob/main/CanonicalHeaderNames.cs
Attention this was just a short run because things take ages otherwise
Types of changes
Checklist
License