-
Notifications
You must be signed in to change notification settings - Fork 867
Create separate operation-specific configs for the Delete, Load, and Save Operations #3387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ashovlin
merged 2 commits into
feature/v4-ddb-separate-config
from
shovlia/v4-ddb-separate-single
Aug 5, 2024
Merged
Create separate operation-specific configs for the Delete, Load, and Save Operations #3387
ashovlin
merged 2 commits into
feature/v4-ddb-separate-config
from
shovlia/v4-ddb-separate-single
Aug 5, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96malhar
suggested changes
Jul 23, 2024
sdk/src/Services/DynamoDBv2/Custom/DataModel/_bcl/Context.Sync.cs
Outdated
Show resolved
Hide resolved
sdk/src/Services/DynamoDBv2/Custom/DataModel/_async/Context.Async.cs
Outdated
Show resolved
Hide resolved
sdk/src/Services/DynamoDBv2/Custom/DataModel/_async/Context.Async.cs
Outdated
Show resolved
Hide resolved
sdk/src/Services/DynamoDBv2/Custom/DataModel/_async/Context.Async.cs
Outdated
Show resolved
Hide resolved
sdk/src/Services/DynamoDBv2/Custom/DataModel/_bcl/IDynamoDBContext.Sync.cs
Outdated
Show resolved
Hide resolved
sdk/src/Services/DynamoDBv2/Custom/DataModel/_bcl/IDynamoDBContext.Sync.cs
Outdated
Show resolved
Hide resolved
sdk/src/Services/DynamoDBv2/Custom/DataModel/_bcl/IDynamoDBContext.Sync.cs
Outdated
Show resolved
Hide resolved
sdk/src/Services/DynamoDBv2/Custom/DataModel/_bcl/IDynamoDBContext.Sync.cs
Outdated
Show resolved
Hide resolved
sdk/src/Services/DynamoDBv2/Custom/DataModel/_netstandard/IDynamoDBContext.Sync.cs
Outdated
Show resolved
Hide resolved
philasmar
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved assuming you address Malhar's comments
…r Delete, Load, and Save operations
2f430a1
to
b49b1ca
Compare
96malhar
approved these changes
Aug 2, 2024
10 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates new operation-specific config objects for the DynamoDB object-mapper operations.
I'm splitting this into 3 PRs:
Motivation and Context
For V4 of the SDK, we're planning to split the shared
DynamoDBOperationConfig
object into operation-specific configs, since the shared object has grown overtime to include properties that are not relevant for all operations.DOTNET-7513
Testing
Ran DynamoDBv2 sln tests locally
Types of changes
Checklist
License