Skip to content

Create separate operation-specific configs for the Delete, Load, and Save Operations #3387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ashovlin
Copy link
Member

Description

Creates new operation-specific config objects for the DynamoDB object-mapper operations.

I'm splitting this into 3 PRs:

  1. Batch and Transact - Create separate operation-specific configs for the object-mapper Batch and Transact operations #3376 (this PR also contains which properties are used where)
  2. Delete/Load/Save - This PR
  3. Query/Scan - Create separate operation-specific configs for the object-mapper Scan and Query operations #3383

Motivation and Context

For V4 of the SDK, we're planning to split the shared DynamoDBOperationConfig object into operation-specific configs, since the shared object has grown overtime to include properties that are not relevant for all operations.

DOTNET-7513

Testing

Ran DynamoDBv2 sln tests locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

Copy link
Contributor

@philasmar philasmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming you address Malhar's comments

@ashovlin ashovlin force-pushed the shovlia/v4-ddb-separate-single branch from 2f430a1 to b49b1ca Compare July 30, 2024 19:31
@ashovlin ashovlin requested a review from 96malhar August 2, 2024 00:11
@ashovlin ashovlin merged commit ad8c25d into feature/v4-ddb-separate-config Aug 5, 2024
1 check passed
@ashovlin ashovlin deleted the shovlia/v4-ddb-separate-single branch August 5, 2024 13:47
ashovlin added a commit that referenced this pull request Aug 7, 2024
ashovlin added a commit that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants