Skip to content

Allow to remove TableNamePrefix on operation level #3476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Dreamescaper
Copy link
Contributor

@Dreamescaper Dreamescaper commented Sep 17, 2024

Fixes #3470

Description

Allow to remove TableNamePrefix in operation-level configs by setting an empty string.

Motivation and Context

In some cases I have most of the tables with suffix, and one or two, which do not correspond to such convention. In this case I would like to be able to use TableNamePrefix globally, but remove it per operation.

Testing

Added unit tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

@96malhar 96malhar requested review from normj and 96malhar September 20, 2024 17:29
@dscpinheiro dscpinheiro added the v4 label Sep 23, 2024
@96malhar
Copy link
Contributor

Verified that all unit tests and integrations tests pass locally.
@dscpinheiro has initiated a full dry-run that will run this commit through our build system.

@96malhar
Copy link
Contributor

96malhar commented Sep 25, 2024

@Dreamescaper Shouldn't the PR title and the commit message read "...remove TableNamePrefix" instead of TableNameSuffix?
Unless I am missing something.

@Dreamescaper Dreamescaper changed the title Allow to remove TableNameSuffix on operation level Allow to remove TableNamePrefix on operation level Sep 26, 2024
@96malhar 96malhar merged commit 5a88f2d into aws:v4-development Sep 26, 2024
@Dreamescaper Dreamescaper deleted the allow_to_remove_table_suffix branch September 26, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants