Support ScannedCount on DynamoDb Document Model

[irina-herciu]

Expose ScannedCount on Amazon.DynamoDBv2.DocumentModel.Search

Description

Add a new ScannedCount property to Search class.
Populate this value internally from the most recent ScanResponse or QueryResponse.
Accumulate ScannedCount value for GetRemaining/GetRemainingAsync

Motivation and Context

#2018

Testing

Unit tests added for new property added

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My code follows the code style of this project
• My change requires a change to the documentation
• I have updated the documentation accordingly
• I have read the README document
• I have added tests to cover my changes
• All new and existing tests passed

License

• I confirm that this pull request can be released under the Apache 2 license

[normj]

My comments are affect both the sync and async code paths.

[normj]

I left minor comment and running the PR through the internal build system. Assuming that is successful I can approve.

[normj]

Can you regenerate the Assembly.tt file so you get an updated Assembly.cs file? Looks like it got merged weird at one point in your branch and the version section is being generated without the #if of the conditional causing the build break. Once you regenenrate the Assembly.cs from the Assembly.tt the #else and #endif should go away.

In case you don't know what I mean in the Generator solution right click on the Assembly.tt file and pick Run Custom Tool

// You can specify all the values or you can default the Build and Revision Numbers 
// by using the '*' as shown below:
// [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("4.0")]
#else
[assembly: AssemblyVersion("4.0.0.6")]
#endif
[assembly: AssemblyFileVersion("4.0.0.6")]

[normj]

I would also suggest avoiding commit the generated unit project file changes. That is how you will get conflicts like you have now. The generated changes will get picked and committed during the next release after this is merged.

[irina-herciu]

Can you regenerate the Assembly.tt file so you get an updated Assembly.cs file? Looks like it got merged weird at one point in your branch and the version section is being generated without the #if of the conditional causing the build break. Once you regenenrate the Assembly.cs from the Assembly.tt the #else and #endif should go away.

In case you don't know what I mean in the Generator solution right click on the Assembly.tt file and pick Run Custom Tool

// You can specify all the values or you can default the Build and Revision Numbers 
// by using the '*' as shown below:
// [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("4.0")]
#else
[assembly: AssemblyVersion("4.0.0.6")]
#endif
[assembly: AssemblyFileVersion("4.0.0.6")]

Assembly.cs was regenerated and the #else and #endif is removed. @normj Can you have another look?

[normj]

Not sure what happen with my previous internal build run that triggered the issues with AssemblyInfo. I assume my local branch was in a bad state and deleted and repulled. And I don't see the same problem. I push the branch through the internal build system again.

You do need to address the merge conflict. That should just mean merge in the latest development branch into your branch. The unit tests for Private5G was deleted in development which is causing the merge conflict.

[normj]

.NET Framework build is failing with the following build errors

C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\Services\DynamoDBv2\UnitTests\Custom\SearchTests.cs(24,27): error CS1729: 'Search' does not contain a constructor that takes 0 arguments [C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\UnitTests\AWSSDK.UnitTests.NetFramework.csproj]
--
2747 | C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\Services\DynamoDBv2\UnitTests\Custom\SearchTests.cs(26,17): error CS0117: 'Search' does not contain a definition for 'SourceTable' [C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\UnitTests\AWSSDK.UnitTests.NetFramework.csproj]
2748 | C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\Services\DynamoDBv2\UnitTests\Custom\SearchTests.cs(27,17): error CS0200: Property or indexer 'Search.TableName' cannot be assigned to -- it is read only [C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\UnitTests\AWSSDK.UnitTests.NetFramework.csproj]
2749 | C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\Services\DynamoDBv2\UnitTests\Custom\SearchTests.cs(28,17): error CS0200: Property or indexer 'Search.CollectResults' cannot be assigned to -- it is read only [C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\UnitTests\AWSSDK.UnitTests.NetFramework.csproj]
2750 | C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\Services\DynamoDBv2\UnitTests\Custom\SearchTests.cs(29,17): error CS0200: Property or indexer 'Search.Filter' cannot be assigned to -- it is read only [C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\UnitTests\AWSSDK.UnitTests.NetFramework.csproj]
2751 | C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\Services\DynamoDBv2\UnitTests\Custom\SearchTests.cs(41,13): error CS1929: 'Search' does not contain a definition for 'Reset' and the best extension method overload 'MockExtensions.Reset(Mock)' requires a receiver of type 'Moq.Mock' [C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\UnitTests\AWSSDK.UnitTests.NetFramework.csproj]
2752 | C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\Services\DynamoDBv2\UnitTests\Custom\SearchTests.cs(68,34): error CS1061: 'Search' does not contain a definition for 'GetNextSetHelper' and no accessible extension method 'GetNextSetHelper' accepting a first argument of type 'Search' could be found (are you missing a using directive or an assembly reference?) [C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\UnitTests\AWSSDK.UnitTests.NetFramework.csproj]
2753 | C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\Services\DynamoDBv2\UnitTests\Custom\SearchTests.cs(110,34): error CS1061: 'Search' does not contain a definition for 'GetRemainingHelper' and no accessible extension method 'GetRemainingHelper' accepting a first argument of type 'Search' could be found (are you missing a using directive or an assembly reference?) [C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\UnitTests\AWSSDK.UnitTests.NetFramework.csproj]
2754 | C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\Services\DynamoDBv2\UnitTests\Custom\SearchTests.cs(135,13): error CS1929: 'Search' does not contain a definition for 'Reset' and the best extension method overload 'MockExtensions.Reset(Mock)' requires a receiver of type 'Moq.Mock' [C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\UnitTests\AWSSDK.UnitTests.NetFramework.csproj]
2755 | 0 Warning(s)
2756 | 9 Error(s)

[irina-herciu]

.NET Framework build is failing with the following build errors

C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\Services\DynamoDBv2\UnitTests\Custom\SearchTests.cs(24,27): error CS1729: 'Search' does not contain a constructor that takes 0 arguments [C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\UnitTests\AWSSDK.UnitTests.NetFramework.csproj]
--
2747 | C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\Services\DynamoDBv2\UnitTests\Custom\SearchTests.cs(26,17): error CS0117: 'Search' does not contain a definition for 'SourceTable' [C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\UnitTests\AWSSDK.UnitTests.NetFramework.csproj]
2748 | C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\Services\DynamoDBv2\UnitTests\Custom\SearchTests.cs(27,17): error CS0200: Property or indexer 'Search.TableName' cannot be assigned to -- it is read only [C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\UnitTests\AWSSDK.UnitTests.NetFramework.csproj]
2749 | C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\Services\DynamoDBv2\UnitTests\Custom\SearchTests.cs(28,17): error CS0200: Property or indexer 'Search.CollectResults' cannot be assigned to -- it is read only [C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\UnitTests\AWSSDK.UnitTests.NetFramework.csproj]
2750 | C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\Services\DynamoDBv2\UnitTests\Custom\SearchTests.cs(29,17): error CS0200: Property or indexer 'Search.Filter' cannot be assigned to -- it is read only [C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\UnitTests\AWSSDK.UnitTests.NetFramework.csproj]
2751 | C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\Services\DynamoDBv2\UnitTests\Custom\SearchTests.cs(41,13): error CS1929: 'Search' does not contain a definition for 'Reset' and the best extension method overload 'MockExtensions.Reset(Mock)' requires a receiver of type 'Moq.Mock' [C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\UnitTests\AWSSDK.UnitTests.NetFramework.csproj]
2752 | C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\Services\DynamoDBv2\UnitTests\Custom\SearchTests.cs(68,34): error CS1061: 'Search' does not contain a definition for 'GetNextSetHelper' and no accessible extension method 'GetNextSetHelper' accepting a first argument of type 'Search' could be found (are you missing a using directive or an assembly reference?) [C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\UnitTests\AWSSDK.UnitTests.NetFramework.csproj]
2753 | C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\Services\DynamoDBv2\UnitTests\Custom\SearchTests.cs(110,34): error CS1061: 'Search' does not contain a definition for 'GetRemainingHelper' and no accessible extension method 'GetRemainingHelper' accepting a first argument of type 'Search' could be found (are you missing a using directive or an assembly reference?) [C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\UnitTests\AWSSDK.UnitTests.NetFramework.csproj]
2754 | C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\Services\DynamoDBv2\UnitTests\Custom\SearchTests.cs(135,13): error CS1929: 'Search' does not contain a definition for 'Reset' and the best extension method overload 'MockExtensions.Reset(Mock)' requires a receiver of type 'Moq.Mock' [C:\codebuild\tmp\output\src1527145343\src\aws-sdk-net\sdk\test\UnitTests\AWSSDK.UnitTests.NetFramework.csproj]
2755 | 0 Warning(s)
2756 | 9 Error(s)

added InternalsVisibleTo for AWSSDK.UnitTests.NetFramework to fix the build