impl http multi value query str parameters #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softprops
commented
Dec 20, 2018
| // multi valued query string parameters are always a super | ||
| // set of singly valued query string parameters, | ||
| // when present, multi-valued query string parameters are preferred | ||
| builder.extension(QueryStringParameters( |
There was a problem hiding this comment.
abstracting over both cases was a conscious decision. I've found multi valued query string parameter cases awkward to work as two separate collections. the thought process behind making StrMap represent both cases was inspired by HeaderMap which abstracts over single and multi valued headers. The semantics here are documented in the public api for users
softprops
changed the title
…alue-query-str-parameters
davidbarsky
approved these changes
Dec 26, 2018
|
Thanks! Looks solid to me. |
|
(There are merge conflicts. I think I merged out of order. I can fix them tomorrow, or you can. Up to you.) |
…nto lambda-http-multivalue-query-str-parameters
|
pushed conflict resolution commit |
davidbarsky
approved these changes
Dec 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
this is a follow on to #58 ( which adds support for (de)serializing multi valued headers. since this is a pull against master it will also contain those changes since this was branched from. That pull should be reviewed first and this second.
There will be one final pull to tie the bow and make the lambda-http crate transparently handle both api gateway and alb events.
By submitting this pull request