Skip to content

Only generate globally unique parameter names for inline functions #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 13, 2025

Conversation

chrisrink10
Copy link
Member

Fixes #1212

Another possible solution to the parameter name issue.

@chrisrink10
Copy link
Member Author

@ikappaki after spending some time thinking about it, this would be more in line with what you initially requested in #1212. I still have some mild concerns about not all cases being covered for inlines, but I think this is probably good enough for the wide majority of cases.

@ikappaki
Copy link
Contributor

Hi @chrisrink10, that is better thanks.

@chrisrink10 chrisrink10 marked this pull request as ready for review April 12, 2025 10:30
@chrisrink10 chrisrink10 merged commit 93be150 into main Apr 13, 2025
12 checks passed
@chrisrink10 chrisrink10 deleted the feature/stop-genname-fn-params branch April 13, 2025 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: preserve function parameter names for improved compatibility with Python libraries
2 participants