refactor ui/borders example to use new children! macro #18962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherBiscardi
added
C-Examples
dj-blume9
reviewed
Apr 28, 2025
dj-blume9
approved these changes
Apr 28, 2025
greeble-dev
approved these changes
Apr 28, 2025
ChristopherBiscardi
added
S-Ready-For-Final-Review
|
CI failures seem unrelated to this PR and it previously passed CI before using TextFont::from_font_size, so moving to ready for final review since it has 2 approvals |
ickshonpe
reviewed
Apr 29, 2025
ickshonpe
reviewed
Apr 29, 2025
ickshonpe
approved these changes
Apr 29, 2025
mockersf
approved these changes
May 4, 2025
andrewzhurov
pushed a commit
to andrewzhurov/bevy
that referenced
this pull request
May 17, 2025
) # Objective Refactor [`examples/ui/borders.rs`](https://github.com/bevyengine/bevy/blob/7f0490655c3ede945e6babc1f1a1f06b13404aa8/examples/ui/borders.rs) to use the new spawning/hierarchy APIs in 0.16. ## Solution This refactor reduces the number of `.spawn` calls from about 16 to 2, using one spawn for each major feature: * camera2d * ui layout The `Children::spawn` relationship API is used to take advantage of `SpawnIter` for the borders examples in each block. Each block of examples now returns a Bundle into its respective variable, which is then used in combination with the new `label` widget which makes use of the new `impl Bundle` return capability. This allows the ui layout to use a single `.spawn` with the `children!` macro. The blocks of examples are still in separate variables because it felt like a useful way to organize it still, even without needing to spawn at those locations. Functionality of the demo hasn't changed, this is just an API/code update. ## Showcase  <details> <summary>Before screenshot</summary>  </details> --------- Co-authored-by: François Mockers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Refactor
examples/ui/borders.rsto use the new spawning/hierarchy APIs in 0.16.Solution
This refactor reduces the number of
.spawncalls from about 16 to 2, using one spawn for each major feature:The
Children::spawnrelationship API is used to take advantage ofSpawnIterfor the borders examples in each block.Each block of examples now returns a Bundle into its respective variable, which is then used in combination with the new
labelwidget which makes use of the newimpl Bundlereturn capability. This allows the ui layout to use a single.spawnwith thechildren!macro.The blocks of examples are still in separate variables because it felt like a useful way to organize it still, even without needing to spawn at those locations.
Functionality of the demo hasn't changed, this is just an API/code update.
Showcase
Before screenshot