Audio sink seek adopted #18971
Merged
Audio sink seek adopted #18971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
ickshonpe
added
C-Feature
janhohenheim
approved these changes
May 3, 2025
janhohenheim
added
the
D-Trivial
Co-authored-by: Jan Hohenheim <[email protected]>
mockersf
approved these changes
May 3, 2025
janhohenheim
added
S-Ready-For-Final-Review
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
andrewzhurov
pushed a commit
to andrewzhurov/bevy
that referenced
this pull request
May 17, 2025
Adopted bevyengine#13869 # Objective Fixes bevyengine#9076 ## Solution Using `rodio`'s `try_seek` ## Testing @ivanstepanovftw added a `seek` system using `AudioSink` to the `audio_control.rs` example. I got it working with .mp3 files, but rodio doesn't support seeking for .ogg and .flac files, so I removed it from the commit (since the assets folder only has .ogg files). Another thing to note is that `try_seek` fails when using `PlaybackMode::Loop`, as `rodio::source::buffered::Buffered` doesn't support `try_seek`. I haven't tested `SpatialAudioSink`. ## Notes I copied the docs for `try_seek` verbatim from `rodio`, and re-exported `rodio::source::SeekError`. I'm not completely confident in those decisions, please let me know if I'm doing anything wrong. </details> --------- Co-authored-by: Ivan Stepanov <[email protected]> Co-authored-by: François Mockers <[email protected]> Co-authored-by: Jan Hohenheim <[email protected]> Co-authored-by: François Mockers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopted #13869
Objective
Fixes #9076
Solution
Using
rodio'stry_seekTesting
@ivanstepanovftw added a
seeksystem usingAudioSinkto theaudio_control.rsexample. I got it working with .mp3 files, but rodio doesn't support seeking for .ogg and .flac files, so I removed it from the commit (since the assets folder only has .ogg files). Another thing to note is thattry_seekfails when usingPlaybackMode::Loop, asrodio::source::buffered::Buffereddoesn't supporttry_seek. I haven't testedSpatialAudioSink.Notes
I copied the docs for
try_seekverbatim fromrodio, and re-exportedrodio::source::SeekError. I'm not completely confident in those decisions, please let me know if I'm doing anything wrong.