Skip to content
This repository was archived by the owner on Feb 7, 2024. It is now read-only.

Laravel 9 support #944

Merged
merged 1 commit into from
Feb 12, 2022
Merged

Laravel 9 support #944

merged 1 commit into from
Feb 12, 2022

Conversation

diegotibi
Copy link
Contributor

I know it's a duplicate but this includes also Symfony 6

@fredsal
Copy link

fredsal commented Feb 10, 2022

Closes #943
Closes #945

@mpociot mpociot merged commit e009061 into beyondcode:master Feb 12, 2022
@mpociot
Copy link
Member

mpociot commented Feb 12, 2022

Thank you very much. Could you send this PR to the 1.x branch as well?

@diegotibi
Copy link
Contributor Author

@mpociot sure, done! #948

@tntsoft
Copy link

tntsoft commented Feb 13, 2022

When can we expect a minor release that will include this commit?

@bmbBAMBUS
Copy link

I still get #945 issue on clear Laravel 9 project.

@diegotibi
Copy link
Contributor Author

I still get #945 issue on clear Laravel 9 project.

That's because a new realease hasn't been tagget yed.

Temporary solution: set your composer dependancy to dev-master

@tntsoft
Copy link

tntsoft commented Feb 14, 2022

@bmbBAMBUS As a temporary solution until a new release is tagged, you can fork the repository and set a VCS at the top of your composer.json:

 "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/[PATH TO YOUR FORKED REPO]"
        }
    ],

@bmbBAMBUS
Copy link

Oh sorry, didn't notice that release hasn't been tagged.

@diegotibi , @tntsoft Thank you for advices!

@mpociot
Copy link
Member

mpociot commented Feb 14, 2022

I just tagged a new 1.x release and will tag a new 2.x beta as well

@lucasantonioedmond
Copy link

Do you have any plans to update the package to Laravel 9?

I tested it now and I still have the same problem.

@tntsoft
Copy link

tntsoft commented Feb 14, 2022

Do you have any plans to update the package to Laravel 9?

I tested it now and I still have the same problem.

This is definitely working. Make sure your composer file import looks like this:

"beyondcode/laravel-websockets": "^1.13",

@lucasantonioedmond
Copy link

Você tem planos de atualizar o pacote para o Laravel 9?
Testei agora e continuo com o mesmo problema.

Isso definitivamente está funcionando. Certifique-se de que a importação do arquivo do compositor tenha esta aparência:

"beyondcode/laravel-websockets": "^1.13",

this is the error

Problem 1
- Root composer.json requires beyondcode/laravel-websockets 1.13 -> satisfiable by beyondcode/laravel-websockets[1.13.0].
- beyondcode/laravel-websockets 1.13.0 requires guzzlehttp/psr7 ^1.5 -> found guzzlehttp/psr7[1.5.0, ..., 1.x-dev] but the package is fixed to 2.1.0 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.

@fredsal
Copy link

fredsal commented Feb 14, 2022

Laravel 9.x Demo

@diegotibi
Copy link
Contributor Author

Probably my fault, I've forgot to bump guzzlehttp on 1.x branch...

@lucasantonioedmond
Copy link

going to upgrade a 1.14 to fix this??

@banyu-wigara
Copy link

going to upgrade a 1.14 to fix this??

Probably ...

@fredsal
Copy link

fredsal commented Feb 16, 2022

composer require "beyondcode/laravel-websockets:dev-master"

@alecpl
Copy link

alecpl commented Feb 23, 2022

Could someone push this to 2.x branch?

@MrReeds
Copy link

MrReeds commented Mar 2, 2022

Could someone push this to 2.x branch?

Since 2.x is not released, why not use the 2.0.0-beta? I tried it and it seems to work

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants