-
Notifications
You must be signed in to change notification settings - Fork 365
add prompts for conceptnet, squad, and google re subset - Lama Dataset #737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add prompts for conceptnet, squad, and google re subset - Lama Dataset #737
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jess will review the other subsets and leave more comments soon, but some of the wording of your prompts are not very natural/grammatical to non-NLP experts. Please see our suggestions.
@KhalidAlt there's a build error could you try to resolve- we can't merge until the build error is fixed:
|
@jzf2101 @KhalidAlt I have started looking into that. This is definitely weird. I can't reproduce that error when I run the tests locally (and I tried on two setups)... will keep you updated once I have debugged this.
|
Hi @VictorSanh, same for me. I tested (show_templates.py) locally, but it did not produce any error. I am not sure what is the reason for this issue. The same error shows up in other PRs : here and here. Please let me know if anything comes up. Thank you. |
…into add_lama_dataset update
@KhalidAlt - per @stephenbach please merge eval-hackathon in your branch and push back |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed some typos, but see the "consistent" prompt for the Squad subset for a critical bug.
Bring back latest changes into this branch
Co-authored-by: Albert Webson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Integrated @jzf2101 and @awebson 's suggestions + merging back latest updates from eval-hackathon main branch to make sure test are up to date + fixing last details
Thank you @KhalidAlt ! merging now
No description provided.