Skip to content

Prompts for crd3 #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
May 20, 2022
Merged

Prompts for crd3 #769

merged 21 commits into from
May 20, 2022

Conversation

shanyas10
Copy link
Contributor

No description provided.

shanyas10 and others added 18 commits May 24, 2021 21:26
@shanyas10
Merge remote-tracking branch 'upstream/main' into main
4364174
@shanyas10
Merge remote-tracking branch 'upstream/main' into main
21d3a40
@shanyas10
Merge remote-tracking branch 'upstream/main' into main
26802d8
@shanyas10
Merge remote-tracking branch 'upstream/main' into main
a412611
@shanyas10
templates for tweets_hate_speech
a13f0b0
@shanyas10
Update templates.yaml
1a027df
@shanyas10
Merge remote-tracking branch 'upstream/main' into main
80adf31
@shanyas10
Create templates.yaml
328b7a7
Merge remote-tracking branch 'upstream/main' into main
cf0f34d
deleting tweets template
e0bf039
@shanyas10
Merge branch 'bigscience-workshop:main' into main
256f472
@shanyas10
Merge branch 'bigscience-workshop:main' into main
d759642
@shanyas10
Merge branch 'bigscience-workshop:main' into main
b5736da
@shanyas10
Merge branch 'bigscience-workshop:main' into main
908769c
@shanyas10
Merge branch 'bigscience-workshop:main' into main
94e01e9
@shanyas10
Merge branch 'bigscience-workshop:main' into main
329c685
adding crd3 prompts
5e0045a
Merge branch 'main' into templates_crd3
02e3a46
@shanyas10 shanyas10 changed the base branch from main to eval-hackathon May 10, 2022 17:50
@shanyas10 shanyas10 changed the title Templates crd3 Prompts for crd3 May 10, 2022
@cjlovering cjlovering mentioned this pull request May 11, 2022
Merged
@stephenbach stephenbach self-assigned this May 17, 2022
@stephenbach
Copy link
Member

Cool dataset! Looks great! Two minor things:

  • Should conversation_to_summary be original task like the others?
  • Some of the dialogs are really long, like 100+ turns, so they won't fit in the context window of most models. Not sure if there's anything you want to do to explicitly handle that, or at least put the instruction first in all cases so that it doesn't get truncated?

@shanyas10
Copy link
Contributor Author

shanyas10 commented May 19, 2022 •
edited
Loading

Hi @stephenbach! Thanks for review

  • Should conversation_to_summary be original task like the others?

Sorry about missing this. Changed this to original task

  • Some of the dialogs are really long, like 100+ turns, so they won't fit in the context window of most models. Not sure if there's anything you want to do to explicitly handle that, or at least put the instruction first in all cases so that it doesn't get truncated?

I have now put the all the instructions at the top to keep them from getting truncated.

stephenbach
stephenbach approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@stephenbach stephenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stephenbach stephenbach merged commit a0a7258 into bigscience-workshop:eval-hackathon May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenbach stephenbach stephenbach approved these changes

Assignees

@stephenbach stephenbach

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shanyas10 @stephenbach