Skip to content

Fix blank results #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2022
Merged

Fix blank results #788

merged 2 commits into from
Jun 25, 2022

Conversation

VictorSanh
Copy link
Member

This is fixing is a bug in how we handle blank results (for instance tydiqa has a bunch of them).

  • standardize how we detect these blank results

Example: PR #766

@VictorSanh VictorSanh requested a review from stephenbach June 25, 2022 18:16
@VictorSanh
Copy link
Member Author

In order to unblock other PRs, i am going to merge things first @stephenbach, but I am still eager to have your check!
We can add another fix if necessary

@VictorSanh VictorSanh merged commit 1dc66cf into eval-hackathon Jun 25, 2022
@VictorSanh VictorSanh deleted the vs/blank_results branch June 25, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant