Skip to content

Allow to store references and eventually delete them #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 1, 2021

Conversation

make-github-pseudonymous-again
Copy link
Member

@make-github-pseudonymous-again make-github-pseudonymous-again commented Apr 1, 2021

Note that this has a significant cost on deletion operations, but not so much on insertion operations. Will have to investigate whether this cost can be reduced. This fixes #100.

PS: The slow-down comes from root fixing and pointer swapping instead of key-swapping.

@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #110 (cab9942) into main (a5c59c5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              main      #110    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           33        36     +3     
  Lines         1351      1572   +221     
==========================================
+ Hits          1351      1572   +221     
Impacted Files Coverage Δ
src/deletion/delete_case0.js 100.00% <100.00%> (ø)
src/deletion/delete_case1.js 100.00% <100.00%> (ø)
src/deletion/delete_case2.js 100.00% <100.00%> (ø)
src/deletion/delete_case3.js 100.00% <100.00%> (ø)
src/deletion/delete_case4.js 100.00% <100.00%> (ø)
src/deletion/delete_case5.js 100.00% <100.00%> (ø)
src/deletion/delete_no_child.js 100.00% <100.00%> (ø)
src/deletion/replace_node.js 100.00% <100.00%> (ø)
src/index.js 100.00% <100.00%> (ø)
src/insertion/insert_case0.js 100.00% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5c59c5...cab9942. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to store references and eventually delete them
1 participant