Mismatch between requirements

[BorisovskiP]

It is not possible to update to magento 2.4.0 community edition because your module requires phpstan/phpstan: ^0.12.24, while magento requires phpstan/phpstan: >=0.12.3 <=0.12.23 (https://packagist.org/packages/magento/community-edition).

[shochdoerfer]

Oh my that sucks big time ;(

Could you try to remove bitexpert/phpstan-magento before upgrading to Magento 2.4 and installing it afterwards again? You still might need to upgrade the phpstan/phpstan version. Not sure if this breaks Magento's internal phpstan setup, but I guess if you are using this module you might not care :)

[shochdoerfer]

@BorisovskiP were you able to get it running the way I described it?

[BorisovskiP]

@shochdoerfer as we have other modules that are still not compatible with 2.4.0, we are waiting on them to update their dependencies so we can proceed with the update. I will notify you when we have done this.

[BorisovskiP]

Removing and re-installing this module does not work as the requirements are still incompatible as stated in the initial description. We just updated the version constraint for phpstan/phpstan.

[sprankhub]

So the big question still is how this issue should be handled by default. I tend to vote for "use the PHPStan version Magento uses". I strongly believe a Magento package should be installable on a clean Magento installation without any issues. Hence, the PHPStan versions must not conflict.
Additionally, we could add a note in the Wiki, which says that "you may want to update the version of PHPStan to get better results" or something.

What do you think, @shochdoerfer?

[shochdoerfer]

Yeah, it kind of sucks to downgrade phpstan again but I am fully with you @sprankhub. It needs to be easy to install the module in any Magento environment and it would suck big time if the phpstan rules shipped with Magento would not work anymore after the phpstan upgrade. So there's only one choice here, sadly.

I don't think we can support multiple phpstan versions, especially not "latest" as usually there's lots of change happening. I'd rather only support the phpstan version that is shipped with the latest, stable Magento version.

[shochdoerfer]

@sprankhub feel free to prep a PR for this, I am way too busy these days to get this going ;(

[shochdoerfer]

Fixed in master, will prepare a new release soonish.

[hostep]

@BorisovskiP: can you answer these questions please?

1. Why do you need bitexpert/phpstan-magento as a direct dependency in a Magento project? What extra features does it provide beside the native implementation in Magento?
2. If you don't use it as a direct dependency in a Magento project, but as a dependency of a module, then I believe this is incorrect and it should be a dev-dependency, is that the case here maybe?

[shochdoerfer]

Following @hostep's remarks in #43 I think we have re-evaluate the approach taken and adapt.

The original goal was to allow people to easily upgrade their Magento 2.3 instance with the bitexpert/phpstan-magento dependency installed to 2.4.x - back then that was not possible to due the hard constraint that Magento has on the phpstan dependency. "Sadly" phpstan's different versions change quite rapidly which leads to the problem @hostep mentions in #43.

I would not want to restrict people using bitexpert/phpstan-magento "only" for module development. We also have the dependency in our Magento project and I would like to keep it as such. If that comes with cost of uninstalling our module & phpstan before upgrading to 2.4 and then reinstalling everything, that would be "ok" for me. If someone installs bitexpert/phpstan-magento on purpose for Magento 2.4, I would not care if the default phpstan configuration in Magento breaks or things fail. The upgrade vom 2.3 to 2.4 should only happen once in the lifespan of a Magento project, I assume.

Ideally, we could keep up with phpstan development and adapt more often than Magento does (or can). Or at least be a bit more independent from Magento's release cycles.

So my plan would be to release a bugfix release that would revert #43 and add a bit of documentation to describe the upgrade process when coming from Magento 2.3. What do you people think? @hostep @BorisovskiP @sprankhub @torhoehn - I would really get this right this time :)