Fix magic methods called directly on dataobject #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Been using this phpstan extension for a couple of days now, it's being very much appreciated!
Today I noticed a small problem, in that I was instantiating a
DataObject
class and called some setters on it. And phpstan was complaining about calling undefined methods on it, even though this extension was installed which was supposed to fix this.The problem was, that this extension only checked on subclasses of
DataObject
and not on instances ofDataObject
itself.This PR fixes this.
I also took the liberty to ignore the
/vendor/
directory in the.gitignore
file which was missing.Awesome work with those captainhook scripts btw! First time I've been using them in practice even though I told myself to look into those after seeing your very nice talk on MM19NL 😉