Skip to content

Fix magic methods called directly on dataobject #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hostep
Copy link
Collaborator

@hostep hostep commented Jul 20, 2019

Hi!

Been using this phpstan extension for a couple of days now, it's being very much appreciated!

Today I noticed a small problem, in that I was instantiating a DataObject class and called some setters on it. And phpstan was complaining about calling undefined methods on it, even though this extension was installed which was supposed to fix this.

The problem was, that this extension only checked on subclasses of DataObject and not on instances of DataObject itself.
This PR fixes this.

I also took the liberty to ignore the /vendor/ directory in the .gitignore file which was missing.

Awesome work with those captainhook scripts btw! First time I've been using them in practice even though I told myself to look into those after seeing your very nice talk on MM19NL 😉

@shochdoerfer
Copy link
Member

Thanks for your contribution! Good catch :)

@shochdoerfer shochdoerfer merged commit 4788be7 into bitExpert:master Jul 21, 2019
@shochdoerfer
Copy link
Member

I usually have set-up a global .gitignore file, thus I tend to forget that other developers don't have that. Thanks for that minor improvement.

@hostep
Copy link
Collaborator Author

hostep commented Jul 21, 2019

Thanks for merging so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants