refactor: add explicit initialisation of the ecc library #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup PR of the discussion here: #4 (comment)
Yes. I would prefer something explicit as in the code snippet below for several reasons:
eccLib
is invalid, then it will fail at theinitEccLib(...)
invocation place (which can make it easy to investigate/debug), instead of failing insidep2tr
orPsbt
p2tr
is used without aneccLib
then the error message can clearly state that: "No ECC Library provided. You must callinitEccLib(...)
with a validTinySecp256k1Interface
instance"TinySecp256k1Interface
toSecp256k1Interface
?eccLib
around)eccLib
option forp2tr
andPsbt
)initEccLib(...)
is optional (only required ifp2tr
is used)initEccLib(...)
multiple times with the sameTinySecp256k1Interface
instance is a noop