Skip to content

Add tip4commit #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2014
Merged

Add tip4commit #222

merged 2 commits into from
Sep 2, 2014

Conversation

abrkn
Copy link
Contributor

@abrkn abrkn commented Jun 22, 2014

I think this is an interesting project, tip4commit, and I'd like to give it a try. The embed image looks terrible, I already opened an issue about it, tip4commit/tip4commit#80

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 7f9356c on tip4commit into d93623e on master.

@dcousens
Copy link
Contributor

Personally I'm more in favour of a shared multi-sig address for donations.
Commit based donations aren't exactly meaningful, its not dissimilar to line based contributions no?

@abrkn
Copy link
Contributor Author

abrkn commented Jun 23, 2014

I don't really know of anything else. It could be the difference between someone bothering and not bothering, in which case it's worked.

@dcousens
Copy link
Contributor

@weilu @kyledrake?

@dcousens
Copy link
Contributor

@abrkn I haven't had a chance to read through it properly, but how does it work? Who holds the keys? Etc

@abrkn
Copy link
Contributor Author

abrkn commented Jun 23, 2014

tip4commit.com holds the coin. I'm quite sure they send the btc using blockchain.info

@weilu
Copy link
Contributor

weilu commented Jun 24, 2014

My vote goes to multi-sig. I'm not too comfortable with a third party holding the coin.

@kyledrake
Copy link
Contributor

Thanks for the idea @abrkn! Looks like the consensus is to use a multisig, so I'm closing this. I do like the idea though! Maybe in the future we'll use both, but for now let's test the multisig idea.

@kyledrake kyledrake closed this Jun 24, 2014
@abrkn
Copy link
Contributor Author

abrkn commented Jun 26, 2014

Okay. Not sure what happens to http://tip4commit.com/projects/735
On Jun 25, 2014 1:30 AM, "Kyle Drake" [email protected] wrote:

Thanks for the idea @abrkn https://github.com/abrkn! Looks like the
consensus is to use a multisig, so I'm closing this. I do like the idea
though! Maybe in the future we'll use both, but for now let's test the
multisig idea.


Reply to this email directly or view it on GitHub
#222 (comment)
.

@dcousens
Copy link
Contributor

@kyledrake what happened to the multisig address we set up for donations? Any reason that hasn't been published in the README?

If that isn't going ahead, maybe we should use tip4commit...

@dcousens dcousens reopened this Aug 30, 2014
@dcousens
Copy link
Contributor

I'm +1 for this, its not the greatest, but until we find/institute something better.

Starship troopers

@abrkn
Copy link
Contributor Author

abrkn commented Sep 1, 2014

I see people are already claiming funds from the tip4commit pool, so why not.

weilu added a commit that referenced this pull request Sep 2, 2014
@weilu weilu merged commit 8cc1f05 into master Sep 2, 2014
@weilu weilu deleted the tip4commit branch September 2, 2014 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants