message: return base64 for sign, make verify work with base64 string #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| function verify(address, signatureBuffer, message, network) { | ||
| function verify(address, signature, message, network) { | ||
| if(!Buffer.isBuffer(signature)) | ||
| var signature = new Buffer(signature, 'base64') |
There was a problem hiding this comment.
Can we add the {} and get rid of the variable re-declaration please?
|
This is again just sidestepping the issue that because devs don't have exposure to |
| @@ -31,18 +31,21 @@ function sign(privKey, message, network) { | |||
| var e = BigInteger.fromBuffer(hash) | |||
| var i = ecdsa.calcPubKeyRecoveryParam(ecparams, e, signature, privKey.pub.Q) | |||
|
|
|||
| return signature.toCompact(i, privKey.pub.compressed) | |||
| return signature.toCompact(i, privKey.pub.compressed).toString('base64') | |||
There was a problem hiding this comment.
I am happy to merge without this change and other fixes applied.
|
Closed in favour of #266 unless @kyledrake comes out of the woodwork to fix the issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #217.
This returns a base64 signature for Message.sign, and allows verify to work with a base64 string (or a buffer). It's using the existing test suite and fixtures.
I'm more than a little confused about the standardization around base64 here, but it does seem to be the convention for everyone using it. Noteworthy is that we actually reduce test code because the fixture signatures are in base64.
We could also make a helper function (ala
signBase64) instead, if we preferred to return a buffer here. But we should definitely provide an easy way for people to do this, since it seems to be common usage.