Makeshift instanceof: check constructor function name instead #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcousens
changed the title
dcousens
changed the title
Merged
|
@weilu Why the change of heart? Based upon our conversation, I'm not sure this is a good idea. Also, I got burned by this after minification... not sure why this was though. |
|
@jprichardson because recently I've encountered a case where instanceof fails because npm dedup failed to resolve multiple copies of the same library. Good point about the minification. I will rebase on @dcousens' change and add tests for that. If it turns out to be an issue, let's close this and explore other options. |
|
Close this as minification indeed cause problems |
|
What were the problems? |
|
edit: it was just an issue with the regex: making it non-greedy fixes it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussions in #255, #274, #231 and IRC, my conclusion is that proper duck typing seems too verbose and not checking types at all seems too dangerous. This is my attempt at finding a middle ground.