Add String() methods to parsed types #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables clients to move back and forth between parsed objects and text patches. The generated patches are semantically equal to the parsed object and should parse to the same object, but may not be byte-for-byte identical to the original input.
Add "a/" and "b/" prefixes to names on "---" and "+++" lines. Reorder lines to match Git. Only print mode lines when the mode is changing.
For now, assert that we produce exactly the same output as the original parsed input. I think these tests would ideally assert that the re-parsed value is the same, but it's kind of annoying to compare File objects without adding an external dependency.
Implement base85 encoding and improve how binary patches are displayed. This fails the tests due to differences between the Git and Go implementation of zlib. I need to decide how to resolve this.
Re-parse our string representation and make sure it is equal. This is important for binary patches due to inconsistencies in DEFLATE implementations, but we do it for text patches too.
This cleans up the code a bit and allows writing everything to a single buffer when formatting a full file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables clients to move back and forth between parsed objects and text patches. The generated patches are semantically equal to the parsed object and should parse to the same object, but may not be byte-for-byte identical to the original input.
At the moment, this only works for text fragments. Marking as a draft while I figure out how to add appropriate tests and decide if I want to support binary patches right now.
Closes #47.