feat(edit): configure /usr overlay #1258
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p5
commented
Apr 9, 2025
cgwalters
reviewed
Apr 9, 2025
p5
force-pushed
the
474-status-usroverlay
branch
from
7361768 to
4e8ec8b
Compare
p5
changed the title
Closes bootc-dev#474 Displays the status of the usroverlay within bootc status. Although not ideal, handles the displaying of the host's filesystem within the image/ostree functions since otherwise it may require the introduction of another "host" block within the status output (i.e. having a "host", "staged", "booted" and "rollback"). Signed-off-by: Robert Sturla <[email protected]>
p5
force-pushed
the
474-status-usroverlay
branch
from
4e8ec8b to
02a2578
Compare
Allows setting the usrOverlay within "bootc edit". Since there's no clean ways (that I'm aware of) for switching back from a writable /usr to a readonly one, this follows the recommended commands in the docs, and lazily unmounts /usr. Signed-off-by: Robert Sturla <[email protected]>
p5
force-pushed
the
474-status-usroverlay
branch
2 times, most recently
from
d4398b2 to
2162466
Compare
Signed-off-by: Robert Sturla <[email protected]>
p5
force-pushed
the
474-status-usroverlay
branch
from
2162466 to
07509f6
Compare
|
This PR has been updated to also include changing the /usr overlay within Overall, I'm quite pleased with how it turned out as it seems to fit the brief. Certainly learned a lot from this one, even if it is quite basic. Please do let me know all the small (or large) things that could be done to improve this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #474
Allows the operator to control the /usr overlay from
bootc edit, and displays the current configuration withinbootc status.Also updates the
bootc usr-overlayto use the new overlay functions, but this should be non-breaking.I've added a "best effort" functionality to
umount /usr, though this seems to be an ostree thing that's not really possible to do in a smooth way - every time I tried it, I received (device busy) errors and /usr remained r/w.Here's the outputs in both human and YAML output formats:
Screencast.From.2025-04-26.20-45-28.webm
As with my previous PRs, I am still extremely new to Rust, so please be harsh with the reviews. I will improve as I attempt more of these.