forked from php/php-src
-
Notifications
You must be signed in to change notification settings - Fork 0
Rfc: inner class2 #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
withinboredom
wants to merge
44
commits into
master
Choose a base branch
from
rfc/inner-class2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 39 commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
a6e974c
add new token
withinboredom ad91fee
create the new grammar
withinboredom 095af03
add new ast pieces
withinboredom 86b0c22
handle modifiers
withinboredom 3ac09a6
handle compiling class declarations
withinboredom 2042a8e
add initial implementation;
withinboredom 6f196e2
get return types working
withinboredom 2e7d28a
make ::class work
withinboredom 92b0dc6
fix failing test
withinboredom f3f2c16
add another class
withinboredom 551e139
add more tests to validate scope resolution keywords
withinboredom 13d8b39
update reflection
withinboredom 3f5e6af
enable visibility
withinboredom 10551f5
add tests for autoloading
withinboredom 78ef744
properly persist classes in opcache
withinboredom 8855f01
handle return type visibility enforcement
withinboredom d1694f9
fix static member access
withinboredom 5386389
move tests
withinboredom 05ab0e0
add more tests and fix access modifiers
withinboredom b510b5f
add support for lexical scope
withinboredom eefea57
handle type visibility
withinboredom 356c0f1
fix opcache
withinboredom d4bf058
fix test
withinboredom c669844
refine some error messages
withinboredom 49a9427
add type check to return type
withinboredom 4313dfb
fix tests
withinboredom 0414f58
temporarily fix this test -- might want to undo this
withinboredom 42eee19
clean up a bit and check readonly
withinboredom 9f654a1
handle visibility of methods
withinboredom 910fc8c
just do not cache -- more trouble than it is worth right now
withinboredom 490ea8b
properly handle lexical scope
withinboredom 15ea80c
handle long names
withinboredom 4ee4332
handle more visibility
withinboredom 566884c
handle constructor visibility
withinboredom 53701d1
prevent static access
withinboredom b33d9c1
start making \\ the separator instead of :>
withinboredom 8d471c7
update tests
withinboredom 17fa07c
finish up edge cases and tests
withinboredom 71a7f6d
fix traits
withinboredom 2767025
make autoloading more effecient
withinboredom 7119f6c
fix attributes
withinboredom a05c5db
properly handle searching up the scope
withinboredom 3f31e15
refactor all-the-things
withinboredom 141995f
refactor all-the-things
withinboredom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.