Skip to content

fix: remove quotation mark when date or datetime is used in queryParams (box/box-codegen#509) #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .codegen.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "engineHash": "3ed6b56", "specHash": "5e023b9", "version": "1.0.0" }
{ "engineHash": "240a5b0", "specHash": "5e023b9", "version": "1.0.0" }
5 changes: 4 additions & 1 deletion docs/events.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,10 @@ See the endpoint docs at

```ts
await client.events.getEvents({
streamType: 'changes' as GetEventsQueryParamsStreamTypeField,
streamType: 'admin_logs' as GetEventsQueryParamsStreamTypeField,
limit: 1,
createdAfter: createdAfterDate,
createdBefore: createdBeforeDate,
} satisfies GetEventsQueryParams);
```

Expand Down
12 changes: 6 additions & 6 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 6 additions & 10 deletions src/managers/events.generated.ts
Original file line number Diff line number Diff line change
Expand Up @@ -230,16 +230,12 @@ export class EventsManager {
['event_type']: queryParams.eventType
? queryParams.eventType.map(toString).join(',')
: undefined,
['created_after']: sdToJson(
queryParams.createdAfter
? serializeDateTime(queryParams.createdAfter)
: undefined
) as string,
['created_before']: sdToJson(
queryParams.createdBefore
? serializeDateTime(queryParams.createdBefore)
: undefined
) as string,
['created_after']: queryParams.createdAfter
? serializeDateTime(queryParams.createdAfter)
: undefined,
['created_before']: queryParams.createdBefore
? serializeDateTime(queryParams.createdBefore)
: undefined,
});
const headersMap: {
readonly [key: string]: string;
Expand Down
19 changes: 19 additions & 0 deletions src/test/events.generated.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ import { serializeRealtimeServers } from '../schemas/realtimeServers.generated.j
import { deserializeRealtimeServers } from '../schemas/realtimeServers.generated.js';
import { serializeRealtimeServer } from '../schemas/realtimeServer.generated.js';
import { deserializeRealtimeServer } from '../schemas/realtimeServer.generated.js';
import { serializeDateTime } from '../internal/utils.js';
import { deserializeDateTime } from '../internal/utils.js';
import { serializeEventSource } from '../schemas/eventSource.generated.js';
import { deserializeEventSource } from '../schemas/eventSource.generated.js';
import { serializeFile } from '../schemas/file.generated.js';
Expand All @@ -26,11 +28,13 @@ import { GetEventsQueryParamsStreamTypeField } from '../managers/events.generate
import { GetEventsQueryParamsEventTypeField } from '../managers/events.generated.js';
import { RealtimeServers } from '../schemas/realtimeServers.generated.js';
import { RealtimeServer } from '../schemas/realtimeServer.generated.js';
import { DateTime } from '../internal/utils.js';
import { getDefaultClient } from './commons.generated.js';
import { EventSource } from '../schemas/eventSource.generated.js';
import { File } from '../schemas/file.generated.js';
import { Folder } from '../schemas/folder.generated.js';
import { User } from '../schemas/user.generated.js';
import { dateTimeFromString } from '../internal/utils.js';
import { toString } from '../internal/utils.js';
import { sdToJson } from '../serialization/json.js';
import { SerializedData } from '../serialization/json.js';
Expand Down Expand Up @@ -137,4 +141,19 @@ test('testGetEventsWithLongPolling', async function testGetEventsWithLongPolling
throw new Error('Assertion failed');
}
});
test('testGetEventsWithDateFilters', async function testGetEventsWithDateFilters(): Promise<any> {
const createdAfterDate: DateTime = dateTimeFromString('2024-06-09T00:00:00Z');
const createdBeforeDate: DateTime = dateTimeFromString(
'2025-06-09T00:00:00Z'
);
const servers: Events = await client.events.getEvents({
streamType: 'admin_logs' as GetEventsQueryParamsStreamTypeField,
limit: 1,
createdAfter: createdAfterDate,
createdBefore: createdBeforeDate,
} satisfies GetEventsQueryParams);
if (!(servers.entries!.length == 1)) {
throw new Error('Assertion failed');
}
});
export {};
Loading