pg-connection-string: avoid clobbering port from queryparams #2833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the connection string is something like:
postgresql://demo:password@/postgres?host=localhost&port=26258
Then the port from the query parameters should be used. Previously, the
parsing function would end up with a null port, and the default port
would end up being used by the connecetion package.
rafiss
force-pushed
the
fix-port-urlparam
branch
from
d3dead4 to
ad4f6c7
Compare
|
Hi @brianc! Any chance this can get reviewed? I believe I've followed the guidelines but let me know if I should do something else to move this forward. |
charmander
approved these changes
Dec 22, 2022
|
@charmander thanks for the review! is anything else needed to merge this? |
|
Hi @brianc I see that this PR was approved, so could you let me know the next step for how I can get this merged? (or if I just need to wait?) |
|
Hi @brianc or @charmander - just checking in to see if this can get merged, since it has been approved already. |
thijs
pushed a commit
to thijs/node-postgres
that referenced
this pull request
Aug 1, 2023
…2833) If the connection string is something like: postgresql://demo:password@/postgres?host=localhost&port=26258 Then the port from the query parameters should be used. Previously, the parsing function would end up with a null port, and the default port would end up being used by the connecetion package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the connection string is something like:
postgresql://demo:password@/postgres?host=localhost&port=26258
Then the port from the query parameters should be used. Previously, the parsing function would end up with a null port, and the default port would end up being used by the connection package.