Skip to content

fix(devcontainer): upgrade node to version 20 #3385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

nigrosimone
Copy link
Contributor

@nigrosimone nigrosimone commented Feb 13, 2025

This PR is only for help contributiors

Upgrade to node 20 and also fix on windows the git history showing most of the files as modified in devcontainer due to this issue fixed by adding * text=auto eol=lf into .gitattributes

Tested on:

  • Windows 11 (latest)
  • VSCODE 1.97.2 (latest)
  • Docker Desktop 4.38.0 (latest)
  • Docker Engine 27.5.1 (latest)

…t may report a large number of modified files that have no differences aside from their line endings.
@brianc
Copy link
Owner

brianc commented Feb 13, 2025

haha i saw the other PR open w/ lots of unrelated changes on it and was like "uh oh! looks like someone's brach was a bit messy!" - thanks for doing a nice clean one. Makes it easy to review! ✅

@brianc brianc merged commit 5a67344 into brianc:master Feb 13, 2025
6 checks passed
@nigrosimone nigrosimone deleted the node-20-container branch February 19, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants