Skip to content

fix: Update node version to fix an issue with the Docker build process. #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2020

Conversation

claudio0603
Copy link
Contributor

Hi there,

I fixed a little issue with the node version in the Dockerfile.
Now it ´s loading the current version of node alpine.

Best regards
Claudio

Copy link
Collaborator

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bufferoverflow
Copy link
Owner

@claudio0603 thanks for the PR! looks good, just the commit lint is complaining. Could you fix it then I can merge.

The command "yarn install" exited with 0.

0.47s$ commitlint-travis

⧗   input: fix: Update node version to fix an issue with the Docker build process.

✖   subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case]

✖   subject may not end with full stop [subject-full-stop]

✖   found 2 problems, 0 warnings

ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

using a commit message like the following should work:

fix: update node version to fix an issue with the Docker build process

@claudio0603
Copy link
Contributor Author

Hi there,
I´ve adjusted the commit message.
Hope it fits better now.

And thanks for this great repo. It helped me alot.

Best regards
Claudio

@bufferoverflow bufferoverflow merged commit 6b4a6db into bufferoverflow:master May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants