Update to match snabbdom 3.5.0 #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
commented
May 16, 2022
Comment on lines
+408
to
+411
| if (vnode.text.isEmpty || vnode.text != oldVnode.text) | ||
| vnode.data.hook | ||
| .flatMap(_.update) | ||
| .foreach(hook => hook(oldVnode, vnode)) |
There was a problem hiding this comment.
AFAICT in our case this becomes an optimization actually, since we were running these update hooks for text nodes already.
armanbilge
commented
May 16, 2022
Comment on lines
1359
to
+1360
| assertEquals(result1.length, 1) | ||
| assertEquals(result2.length, 1) | ||
| assertEquals(result2.length, 0) |
There was a problem hiding this comment.
And this is the optimization kicking-in, I believe. It only affects the text node, since the text is unchanged in this instance.
Codecov Report
@@ Coverage Diff @@
## main #29 +/- ##
==========================================
+ Coverage 86.16% 86.18% +0.02%
==========================================
Files 19 19
Lines 542 543 +1
Branches 60 53 -7
==========================================
+ Hits 467 468 +1
Misses 75 75
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not really sure what I'm doing, so please review carefully :)