can support for slevomat/coding-standard v6 be removed?

[swiffer]

cakephp-codesniffer/CakePHP/ruleset.xml

Line 157 in fba3e43

<!-- Property names used in slevomat/coding-standard v6 -->

the ruleset config adds configuration entries that no longer exist in current versions of slevomat/conding-standard leading to deprecations in PHP 8.2

Deprecated: Creation of dynamic property SlevomatCodingStandard\Sniffs\TypeHints\DeclareStrictTypesSniff::$newlinesCountAfterDeclare is deprecated

Is slevomat/coding-standard v6 support still required ? v8 covers [PHP 7.2 - PHP 8.2](php: ^7.2 || ^8.0) and should be fine for projects running CakePHP 4?

ref: squizlabs/PHP_CodeSniffer#3629 (comment)

[othercorey]

I reproduced this. Looks like we need to bump the minimum slevomat in a new minor and drop old configs.

[othercorey]

Are you seeing any errors beyond the warning?

[swiffer]

No, otherwise working Just fine. (The warning leads to phpcs Not working in vscode / Run on save in my dev env - that's my Driver for getting this fixed)

[ADmad]

The warning leads to phpcs Not working in vscode..

That's bad for usability.

@othercorey I guess we should just keep v8 of slevomat CS and do a new minor for our 4.x.

[othercorey]

Dropped in 4.7.0 release.