Skip to content

[v12] refactor: exclude hidden elements by defaults #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 17, 2023

Conversation

mdjastrzebski
Copy link
Member

Summary

  • Switch defaultIncludeHiddenElements: false
  • Update tests
  • Update docs

Test plan

All checks should pass. Pls review testing code.

@mdjastrzebski mdjastrzebski changed the title Refactor/exclude hidden elements [v12] exclude hidden elements by defaults Feb 14, 2023
@mdjastrzebski mdjastrzebski changed the title [v12] exclude hidden elements by defaults [v12] refactor: exclude hidden elements by defaults Feb 14, 2023
Base automatically changed from refactor/enable-breaking-changes to v12 February 16, 2023 13:27
@mdjastrzebski mdjastrzebski force-pushed the refactor/exclude-hidden-elements branch from 393e065 to 19e1cdc Compare February 16, 2023 13:30
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Base: 96.09% // Head: 96.09% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (34a338b) compared to base (20a8768).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##              v12    #1317   +/-   ##
=======================================
  Coverage   96.09%   96.09%           
=======================================
  Files          49       49           
  Lines        3275     3280    +5     
  Branches      489      492    +3     
=======================================
+ Hits         3147     3152    +5     
  Misses        128      128           
Impacted Files Coverage Δ
src/config.ts 100.00% <100.00%> (ø)
src/helpers/accessiblity.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mdjastrzebski mdjastrzebski merged this pull request into v12 Feb 17, 2023
@mdjastrzebski mdjastrzebski deleted the refactor/exclude-hidden-elements branch February 17, 2023 11:36
@mdjastrzebski mdjastrzebski mentioned this pull request Feb 17, 2023
6 tasks
mdjastrzebski added a commit that referenced this pull request Feb 20, 2023
mdjastrzebski added a commit that referenced this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants