Skip to content

fix: container enumeration #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 1, 2023
Merged

fix: container enumeration #1352

merged 3 commits into from
Mar 1, 2023

Conversation

mdjastrzebski
Copy link
Member

@mdjastrzebski mdjastrzebski commented Feb 28, 2023

Summary

Make deprecated container property non enumerable to avoid triggering exception when used in e.g. object rest destructuring.

Resolves #1350.

Test plan

Added unit test for rest destructuring.

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (211907a) 96.09% compared to head (71fc766) 96.09%.

❗ Current head 71fc766 differs from pull request most recent head 6395a23. Consider uploading reports for the commit 6395a23 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              v12    #1352   +/-   ##
=======================================
  Coverage   96.09%   96.09%           
=======================================
  Files          49       49           
  Lines        3280     3281    +1     
  Branches      492      491    -1     
=======================================
+ Hits         3152     3153    +1     
  Misses        128      128           
Impacted Files Coverage Δ
src/screen.ts 100.00% <ø> (ø)
src/render.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mdjastrzebski mdjastrzebski merged commit c0ac70b into v12 Mar 1, 2023
@mdjastrzebski mdjastrzebski deleted the fix/container-enumeration branch March 1, 2023 09:54
@mdjastrzebski mdjastrzebski mentioned this pull request Mar 7, 2023
6 tasks
mdjastrzebski added a commit that referenced this pull request Mar 8, 2023
* fix: make container non-enumerable

* chore: fix lint, typecheck

* chore: code comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'container' property has been renamed to 'UNSAFE_root'
4 participants