fix: container enumeration #1352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjastrzebski
requested review from
AugustinLF,
thymikee,
pierrezimmermannbam and
MattAgn
and removed request for
AugustinLF and
thymikee
pierrezimmermannbam
approved these changes
Feb 28, 2023
MattAgn
approved these changes
Mar 1, 2023
AugustinLF
approved these changes
Mar 1, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v12 #1352 +/- ##
=======================================
Coverage 96.09% 96.09%
=======================================
Files 49 49
Lines 3280 3281 +1
Branches 492 491 -1
=======================================
+ Hits 3152 3153 +1
Misses 128 128
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mdjastrzebski
added a commit
that referenced
this pull request
Mar 8, 2023
* fix: make container non-enumerable * chore: fix lint, typecheck * chore: code comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make deprecated
containerproperty non enumerable to avoid triggering exception when used in e.g. object rest destructuring.Resolves #1350.
Test plan
Added unit test for rest destructuring.