chore(breaking): Remove deprecated APIs #179
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
changed the title
|
Let's hold off with merging for a bit. I'd like to release a11y matchers and maybe some other improvements, and remove those just before 2.0 |
thymikee
requested changes
Feb 1, 2020
There was a problem hiding this comment.
Let's make it easier for people to migrate by following what React does:
- add a notice about deprecation and alias unsafe queries with
UNSAFE_prefix in 1.x - remove non-prefixed unsafe queries in 2.0, leave
UNSAFE_ones with either no or different deprecation message (yet to be decided)
Also, let's exclude shallow from this PR. I'd like to move it to another package before removing it and also provide a deprecation notice in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove deprecated APIs for
2.0release.Things removed:
shallow API*ByPropsqueries*ByTypequeries*ByNamequeriesTODO:
Test plan
Tests passing.