Skip to content

imp: Re-alias deprecated matchers and warn #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2020
Merged

imp: Re-alias deprecated matchers and warn #261

merged 2 commits into from
Mar 18, 2020

Conversation

Esemesek
Copy link
Collaborator

@Esemesek Esemesek commented Mar 17, 2020

Summary

Re-alias every deprecated method with UNSAFE_ prefix and add a warning.
For now, I decided not to include any warnings for re-aliased functions (but we should definitely include some messages after we delete original methods)

cc @thymikee

Test plan

Everything is logged correctly.

https://app.circleci.com/pipelines/github/callstack/react-native-testing-library/758/workflows/e3d488a4-dd12-4e68-9bae-7cbc7951bd96/jobs/2865/parallel-runs/0/steps/0-102

@Esemesek Esemesek requested a review from thymikee March 17, 2020 23:51
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, but let's keep ByName on the removal path, it spawns warnings for more than a year now I think

@thymikee thymikee merged commit 960080d into master Mar 18, 2020
@thymikee thymikee deleted the deprecation branch March 18, 2020 09:30
@Esemesek Esemesek mentioned this pull request Mar 18, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants