-
Notifications
You must be signed in to change notification settings - Fork 421
Adds can.Compute, and "compute" type and setter / getter paring for define pugin #1486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@daffl I'm assigning this to you as this might break a few of the |
From the looks of it, this is now possible too:
|
}; | ||
compute.bind = can.proxy(internalCompute.bind, internalCompute); | ||
compute.unbind = can.proxy(internalCompute.unbind, internalCompute); | ||
compute.isComputed = can.proxy(internalCompute.isComputed, internalCompute); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this supposed to work? For some reason it is only breaking for Mootools but can.proxy(true, internalCompute)
doesn't seem right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isComputed is a boolean. So I think this should be compute.isComputed = true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my playing with this branch I noticed that isComputed was no longer a boolean
and was uber confused. Glad that's cleared up.
Adds can.Compute, and "compute" type and setter / getter paring for define pugin
You can: