/dbname in hostname #5
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the following resource:
You will end up with '%/dbname' in the Host column of the mysql.user table, when it should just be a '%'.
This pull request is embarassing, and shows just how much of a Ruby newb I am. While it technically works, it violates DRY in every way. Please, please, please show me how to pull this regex out into a method. Note that the same regex is used in lib/puppet/provider/database_grant/mysql.rb