Skip to content
This repository was archived by the owner on Nov 9, 2017. It is now read-only.

Fix travis #112

Closed
wants to merge 4 commits into from
Closed

Fix travis #112

wants to merge 4 commits into from

Conversation

brycefisher
Copy link
Contributor

As of 3:36pm PST, this branch is green on Travis-ci.

Apologies for messy branch. Do you want me to clean up the history and issue a new PR?

brycefisher and others added 4 commits July 10, 2014 22:50
Try using the --rpath flag, since this is disabled by default in the newest rust nightlies.
Now with the proper syntax for rpath
Make clean was deleting the rust-openssl libraries that we needed.
@Ogeon
Copy link
Collaborator

Ogeon commented Jul 13, 2014

It would be nice if you could rebase it to compress them into a single commit.

@chris-morgan
Copy link
Owner

The LD_LIBRARY_PATH should be superfluous since rust-lang/rust#15597. And I’m not at all eager about adding rpaths like that in the makefile; it’s a nasty hack that we should not consider ourselves free to do. Need to assess the situation again to determine what is actually necessary.

@brycefisher
Copy link
Contributor Author

I appreciate it, @chris-morgan!

I'd love to keep travis green, but I definitely don't want to add nasty hacks. It looks like travis is green now anyway.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants