Skip to content
This repository was archived by the owner on Nov 9, 2017. It is now read-only.

Update for rust master #46

Closed
wants to merge 1 commit into from
Closed

Conversation

ehsanul
Copy link

@ehsanul ehsanul commented Nov 26, 2013

spawn_with and spawn_supervised have been removed in this pull request: rust-lang/rust#10603

I also looked up the commit that added spawn_supervised: 32a28cd

Seems to be to ensure the server keeps running even if a handler fails. But I've tried randomly inducing failure in the keep-alive loop here, and the parent task seems to keep running just fine.

spawn_with and spawn_supervised have been removed in this pull request: rust-lang/rust#10603
@chris-morgan
Copy link
Owner

#45 has already subsumed the functionality here, so I'm closing this one.

spawn_supervised was indeed used to prevent failure in the handling of one request from killing the entire server; linked failure was removed altogether in rust-lang/rust#10603, so this is no longer a problem and we can indeed switch to just using plain spawn.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants