add intellij integration test structure #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
afucher
commented
Mar 31, 2025
•
afucher
commented
- Setup structure
- Add test workflow
- Implement one test case
|
afucher
commented
Apr 22, 2025
| action | ||
| (com.intellij.openapi.actionSystem.AnActionEvent/createFromDataContext action-id nil context)))))) | ||
|
|
||
| (defn wait-lsp-start |
There was a problem hiding this comment.
For some reason using the same approach from clj4intellij with promises makes the test to hang forever 😢 So, we decided to create a specific function in this project to use a timeout instead of promise to wait.
acamargo
approved these changes
Apr 22, 2025
ericdallo
reviewed
Apr 22, 2025
src/test/clojure/com/github/clojure_lsp/intellij/test_utils.clj
Outdated
Show resolved
Hide resolved
ericdallo
reviewed
Apr 22, 2025
src/test/clojure/com/github/clojure_lsp/intellij/slurp_action_test.clj
Outdated
Show resolved
Hide resolved
ericdallo
reviewed
Apr 22, 2025
src/test/clojure/com/github/clojure_lsp/intellij/slurp_action_test.clj
Outdated
Show resolved
Hide resolved
ericdallo
reviewed
Apr 22, 2025
| :or {millis 1000 | ||
| timeout 10000}}] | ||
| (let [start-time (System/currentTimeMillis)] | ||
| (loop [] |
There was a problem hiding this comment.
clojure.core.async/alts! is perfect for those do or timeout task, but it's ok to keep it as it is
ericdallo
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.