Update description of CDI spec directories #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bart0sh
reviewed
Aug 8, 2024
README.md
Outdated
| and containerd | ||
| - Container runtime should be able to find the CDI file by the device name and | ||
| update the container config using CDI file content. | ||
| command line parameters for podman or using container annotations or CRI |
There was a problem hiding this comment.
Should Docker be mentioned here?
This change improves the description of the CDI spec directories. The support for YAML files is called out and the exact file extensions are mentioned. Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
update-dir-description
branch
from
ded57cf to
e3ab801
Compare
|
/lgtm |
bart0sh
approved these changes
Aug 8, 2024
reidpr
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves the description of the CDI spec directories. The support for YAML files is called out and the exact file extensions are mentioned.