Remove specs-go/parsing APIs #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bart0sh
force-pushed
the
PR022-specs-go-remove-parsing-functions
branch
from
236c27a to
82711f0
Compare
Signed-off-by: Ed Bartosh <[email protected]>
bart0sh
force-pushed
the
PR022-specs-go-remove-parsing-functions
branch
from
82711f0 to
8de8603
Compare
elezar
reviewed
Aug 9, 2024
| if strings.ContainsRune(class, '.') { | ||
| return true | ||
| } | ||
| if !strings.Contains(spec.Kind, "/") { |
There was a problem hiding this comment.
There's a subtle difference here in that if there is no / the class is assumed to equal the Kind. and that would be checked for a ..
I don't think that's used in practice though.
There was a problem hiding this comment.
OK. Wait, I've just seen the other conditional below.
|
@elezar Thank you for the fast review & merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got rid of using
parseQualifierandisLetterAPIs in version.go