Bump spec version to v0.9.0 #252
Conversation
Signed-off-by: Evan Lezar <[email protected]>
| // requiresV090 returns true if the spec uses v0.9.0 features. | ||
| // Since the v0.9.0 spec bump was due to moving the minimum version checks to | ||
| // the spec package, there are no explicit spec changes. | ||
| func requiresV090(_ *Spec) bool { | ||
| return false | ||
| } | ||
|
|
There was a problem hiding this comment.
This is just out of curiosity: is there any difference between validSpecVersions[$VERSION] being nil and it being a (requiredFunc) function which always returns false ?
There was a problem hiding this comment.
There is no difference functionally. We could remove the requiresV080 and requiresV090 functions entirely.
There was a problem hiding this comment.
Ok. Just wanted to make sure I understand it correctly. From my perspective, there is no need to remove those functions to get this merged. There is one benefit to having those functions there as opposed to omitting them: it spells out that this bit of functionality has been considered/taken care of, but it just happens that there are no new additions to the Spec in those versions.
|
Closing as #257 is merged. |
No description provided.