fix: don't crash in cache refresh/update with nil fsnotify watcher. #254

klihub · 2025-02-22T15:09:47Z

Don't crash if fsnotify.Watcher creation fails, for instance due to being out of file descriptors. See moby/buildkit#5767 for an example.

Fixes #253.

bart0sh · 2025-02-23T06:28:18Z

pkg/cdi/cache.go

+	// (but with autoRefresh left on). One known case when this can happen is
+	// if we have too many open files. In that case we always return true and
+	// force a refresh.
+	if w.watcher == nil {


Is it possible to check it earlier, e.g. when w.watcher is about to be assigned to nil? Or we want to keep it nil in a hope that it will be changed at some point?

If I recall correctly we guard setting the watchers in a Mutex. Does that help to ensure this does not happen?

Is it possible to check it earlier, e.g. when w.watcher is about to be assigned to nil? Or we want to keep it nil in a hope that it will be changed at some point?

Yes, I wanted to leave the door open for a better than the current recovery once we can again create fds (and that would probably be retrying a setup here).

In this very PR, I wanted to roll a minimum-footprint fix that we can review and merge quickly, and be fairly confident that it is safe to cherry pick and tag a v0.8.1.

If I recall correctly we guard setting the watchers in a Mutex. Does that help to ensure this does not happen?

This happens if we hit EMFILE while trying to create the watch.

pkg/cdi/cache_test.go

elezar

Thanks @klihub.

I think the changes look good in principle.

@bart0sh feel free to merge once you're happy so that we can create a branch and cherry-pick this change and possibly the mount ordering one.

Signed-off-by: Krisztian Litkey <[email protected]>

Don't crash in update() if we fail to create an fsnotify watch. This can happen if we have too many open files. In this case we now record a failure for all configured spec directories and in update we always trigger a refresh. If the process if ever able to create new file descriptors the cache becomes functional but in a 'always implicitly fully refreshed' mode instead of auto- refreshed. It's not entirely clear what is the best option to deal with a failed watch creation. Being out of file descriptors typically results in a cascading chain of errors which the process does not usually survive. This fix aims for minimal footprint. On failed watch creation it does not render the cache fully unusable. If the process is ever able to create new file descriptors again the cache also becomes functional, but instead of autorefreshed mode it will be in an 'always implicitly fully refreshed' mode. Signed-off-by: Krisztian Litkey <[email protected]>

Test that the cache indeed recovers functionally if the process ever recovers from not being able to create new file descriptors. Signed-off-by: Krisztian Litkey <[email protected]>

This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/moby/buildkit](https://redirect.github.com/moby/buildkit) | `v0.20.0` -> `v0.20.1` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fmoby%2fbuildkit/v0.20.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fmoby%2fbuildkit/v0.20.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fmoby%2fbuildkit/v0.20.0/v0.20.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fmoby%2fbuildkit/v0.20.0/v0.20.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>moby/buildkit (github.com/moby/buildkit)</summary> ### [`v0.20.1`](https://redirect.github.com/moby/buildkit/releases/tag/v0.20.1) [Compare Source](https://redirect.github.com/moby/buildkit/compare/v0.20.0...v0.20.1) Welcome to the v0.20.1 release of buildkit! Please try out the release binaries and report any issues at https://github.com/moby/buildkit/issues. ##### Contributors - Tõnis Tiigi - Akihiro Suda - CrazyMax ##### Notable Changes - Fix panic during CDI manager initialization. [#5769](https://redirect.github.com/moby/buildkit/issues/5769) [cncf-tags/container-device-interface#254](https://redirect.github.com/cncf-tags/container-device-interface/issues/254) - Fix gRPC message size when writing SBOMs. [#5798](https://redirect.github.com/moby/buildkit/issues/5798) [containerd/containerd#11457](https://redirect.github.com/containerd/containerd/issues/11457) - Update azblob client retries for GitHub Actions cache backend. [#5797](https://redirect.github.com/moby/buildkit/issues/5797) [tonistiigi/go-actions-cache#33](https://redirect.github.com/tonistiigi/go-actions-cache/issues/33) - Embedded binfmt emulators in the release image have been updated to QEMU v9.2.2. [#5808](https://redirect.github.com/moby/buildkit/issues/5808) - Update documentation and examples for rootless mode. [#5765](https://redirect.github.com/moby/buildkit/issues/5765) ##### Dependency Changes - **github.com/containerd/containerd/v2** v2.0.2 -> v2.0.3 - **github.com/tonistiigi/go-actions-cache** [`1a5174a`](https://redirect.github.com/moby/buildkit/commit/1a5174abd055) -> [`3e9a664`](https://redirect.github.com/moby/buildkit/commit/3e9a6642607f) - **tags.cncf.io/container-device-interface** v0.8.0 -> v0.8.1 Previous release can be found at [v0.20.0](https://redirect.github.com/moby/buildkit/releases/tag/v0.20.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/hetznercloud/csi-driver).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [moby/buildkit](https://redirect.github.com/moby/buildkit) | | minor | `0.19.0` -> `0.22.0` | | [moby/buildkit](https://redirect.github.com/moby/buildkit) | final | minor | `v0.19.0-rootless` -> `v0.22.0-rootless` | | [moby/buildkit](https://redirect.github.com/moby/buildkit) | stage | minor | `v0.19.0` -> `v0.22.0` | --- ### Release Notes <details> <summary>moby/buildkit (moby/buildkit)</summary> ### [`v0.22.0`](https://redirect.github.com/moby/buildkit/releases/tag/v0.22.0) [Compare Source](https://redirect.github.com/moby/buildkit/compare/v0.21.1...v0.22.0) Welcome to the v0.22.0 release of buildkit! Please try out the release binaries and report any issues at https://github.com/moby/buildkit/issues. ##### Contributors - Tõnis Tiigi - CrazyMax - Akihiro Suda - Sebastiaan van Stijn - Alberto Garcia Hierro - Anthony Nandaa - Jonathan A. Sternberg - Bertrand Paquet - Gleb Nebolyubov - Justin Chadwell - liulanzheng ##### Notable Changes - Add checksum support to Git source. [#5975](https://redirect.github.com/moby/buildkit/issues/5975) - Allow duration based filters on diskusage requests. [#5455](https://redirect.github.com/moby/buildkit/issues/5455) - Ignore Apple extended file attributes during copy. [#5937](https://redirect.github.com/moby/buildkit/issues/5937) [tonistiigi/fsutil#235](https://redirect.github.com/tonistiigi/fsutil/pull/235) - Support for building overlaybd images. [#3867](https://redirect.github.com/moby/buildkit/issues/3867) [docs](https://redirect.github.com/moby/buildkit/blob/master/docs/overlaybd.md) - Improve error message for registry and local cache export when using `image-manifest` and `oci-mediatypes` options. [#5966](https://redirect.github.com/moby/buildkit/issues/5966) - Fix supported platforms reported by the worker. [#5968](https://redirect.github.com/moby/buildkit/issues/5968) - Fix CDI device request by class annotation. [#5969](https://redirect.github.com/moby/buildkit/issues/5969) - Fix panic when using a tiny terminal. [#5967](https://redirect.github.com/moby/buildkit/issues/5967) - CNI plugins have been updated to v1.7.1. [#5533](https://redirect.github.com/moby/buildkit/issues/5533) ##### Dependency Changes - **github.com/containerd/accelerated-container-image** v1.2.3 ***new*** - **github.com/containerd/containerd/v2** v2.0.4 -> v2.0.5 - **github.com/docker/cli** v28.0.4 -> v28.1.1 - **github.com/docker/docker** v28.0.4 -> v28.1.1 - **github.com/moby/go-archive** [`21f3f33`](https://redirect.github.com/moby/buildkit/commit/21f3f3385ab7) -> v0.1.0 - **github.com/moby/sys/atomicwriter** v0.1.0 ***new*** - **github.com/tonistiigi/fsutil** [`5b74a7a`](https://redirect.github.com/moby/buildkit/commit/5b74a7ad7583) -> [`3f76f81`](https://redirect.github.com/moby/buildkit/commit/3f76f8130144) - **github.com/vbatts/tar-split** v0.11.6 -> v0.12.1 Previous release can be found at [v0.21.1](https://redirect.github.com/moby/buildkit/releases/tag/v0.21.1) ### [`v0.21.1`](https://redirect.github.com/moby/buildkit/releases/tag/v0.21.1) [Compare Source](https://redirect.github.com/moby/buildkit/compare/v0.21.0...v0.21.1) Welcome to the v0.21.1 release of buildkit! Please try out the release binaries and report any issues at https://github.com/moby/buildkit/issues. ##### Contributors - Tõnis Tiigi - Akihiro Suda - Gleb Nebolyubov ##### Notable Changes - Builtin Dockerfile frontend has been updated to [v1.15.1](https://redirect.github.com/moby/buildkit/releases/tag/dockerfile%2F1.15.1). - Fix `buildctl --tlsdir` for non-cert-manager.io tls certificate naming. [#5950](https://redirect.github.com/moby/buildkit/issues/5950) - Fix panic when null cache options were sent using solve grpc API. [#5925](https://redirect.github.com/moby/buildkit/issues/5925) ##### Dependency Changes This release has no dependency changes Previous release can be found at [v0.21.0](https://redirect.github.com/moby/buildkit/releases/tag/v0.21.0) ### [`v0.21.0`](https://redirect.github.com/moby/buildkit/releases/tag/v0.21.0) [Compare Source](https://redirect.github.com/moby/buildkit/compare/v0.20.2...v0.21.0) Welcome to the v0.21.0 release of buildkit! Please try out the release binaries and report any issues at https://github.com/moby/buildkit/issues. ##### Contributors - Tõnis Tiigi - CrazyMax - Akihiro Suda - Jonathan A. Sternberg - Anthony Nandaa - Sebastiaan van Stijn - Dan Duvall - Austin Vazquez - Billy Owire - Derek McGowan - Gleb Nebolyubov - Michael Korn ##### Notable Changes - Builtin Dockerfile frontend has been updated to v1.15.0. [changelog](https://redirect.github.com/moby/buildkit/releases/tag/dockerfile%2F1.15.0) - Runc container runtime has been updated to v1.2.6. [#5845](https://redirect.github.com/moby/buildkit/issues/5845) - The cache manifest created by `--cache-to` now defaults to OCI artifact manifest (instead of OCI image index). For old behavior, set `image-manifest=false`. [#5864](https://redirect.github.com/moby/buildkit/issues/5864) - The cache timeout for registry credentials has been reduced from 10 min to 5 min. [#5859](https://redirect.github.com/moby/buildkit/issues/5859) - Buildctl `--tlsdir` option now allows filenames compatible with `cert-manager.io`. [#5886](https://redirect.github.com/moby/buildkit/issues/5886) - Update free-space filter GC/prune filter to not remove all data when no max-space value is set. [#5827](https://redirect.github.com/moby/buildkit/issues/5827) - Mitigate GitHub Actions cache v2 flakiness. [#5805](https://redirect.github.com/moby/buildkit/issues/5805) - Add autoallow and entitlements support to CDI devices. [#5742](https://redirect.github.com/moby/buildkit/issues/5742) - Support authentication in LLB for Git and HTTP. [#5733](https://redirect.github.com/moby/buildkit/issues/5733) - Support for adding additional request header fields for HTTP sources. [#5732](https://redirect.github.com/moby/buildkit/issues/5732) - OpenTelemetry traces now contain spans for layer extraction. [#5831](https://redirect.github.com/moby/buildkit/issues/5831) - containerd image exporter creates dangling images by default. [#5858](https://redirect.github.com/moby/buildkit/issues/5858) - Add support for bind and cache mounts for WCOW. [#5708](https://redirect.github.com/moby/buildkit/issues/5708) - Add session exporter capability. [#5907](https://redirect.github.com/moby/buildkit/issues/5907) [#5908](https://redirect.github.com/moby/buildkit/issues/5908) - Add metadata-only transfer option for local source. [#5897](https://redirect.github.com/moby/buildkit/issues/5897) - Fix X mode to be Linux-compatible for file operations using chmod. [#5850](https://redirect.github.com/moby/buildkit/issues/5850) - Fix `--chmod` when applied to parent directories. [#5788](https://redirect.github.com/moby/buildkit/issues/5788) - Fix missing user-agent when buildkit requests layers from the registry. [#5834](https://redirect.github.com/moby/buildkit/issues/5834) - Fix missing user-agent for GitHub Actions importer. [#5759](https://redirect.github.com/moby/buildkit/issues/5759) [#5760](https://redirect.github.com/moby/buildkit/issues/5760) - Fix reading secrets from any session on parallel build requests. [#5833](https://redirect.github.com/moby/buildkit/issues/5833) - Fix race condition causing "file used by another process" errors with WCOW. [#5885](https://redirect.github.com/moby/buildkit/issues/5885) ##### Dependency Changes - **github.com/docker/cli** v27.5.1 -> v28.0.4 - **github.com/docker/docker** v27.5.1 -> v28.0.4 - **github.com/docker/docker-credential-helpers** v0.8.2 -> v0.9.3 - **github.com/golang-jwt/jwt/v5** v5.2.1 -> v5.2.2 - **github.com/google/go-cmp** v0.6.0 -> v0.7.0 - **github.com/klauspost/compress** v1.17.11 -> v1.18.0 - **github.com/moby/go-archive** [`21f3f33`](https://redirect.github.com/moby/buildkit/commit/21f3f3385ab7) ***new*** - **github.com/moby/sys/user** v0.3.0 -> v0.4.0 - **github.com/opencontainers/image-spec** v1.1.0 -> v1.1.1 - **github.com/tonistiigi/dchapes-mode** [`ca0759f`](https://redirect.github.com/moby/buildkit/commit/ca0759fec205) -> [`73d941a`](https://redirect.github.com/moby/buildkit/commit/73d941a28323) - **github.com/tonistiigi/fsutil** [`b14e27f`](https://redirect.github.com/moby/buildkit/commit/b14e27f4135a) -> [`5b74a7a`](https://redirect.github.com/moby/buildkit/commit/5b74a7ad7583) - **golang.org/x/crypto** v0.31.0 -> v0.37.0 - **golang.org/x/exp** [`2d47ceb`](https://redirect.github.com/moby/buildkit/commit/2d47ceb2692f) -> [`7e4ce0a`](https://redirect.github.com/moby/buildkit/commit/7e4ce0ab07d0) - **golang.org/x/mod** v0.22.0 -> v0.24.0 - **golang.org/x/net** v0.33.0 -> v0.39.0 - **golang.org/x/sync** v0.10.0 -> v0.13.0 - **golang.org/x/sys** v0.29.0 -> v0.32.0 - **golang.org/x/text** v0.21.0 -> v0.24.0 - **golang.org/x/time** v0.6.0 -> v0.11.0 - **tags.cncf.io/container-device-interface** v0.8.1 -> v1.0.1 - **tags.cncf.io/container-device-interface/specs-go** v0.8.0 -> v1.0.0 Previous release can be found at [v0.20.2](https://redirect.github.com/moby/buildkit/releases/tag/v0.20.2) ### [`v0.20.2`](https://redirect.github.com/moby/buildkit/releases/tag/v0.20.2) [Compare Source](https://redirect.github.com/moby/buildkit/compare/v0.20.1...v0.20.2) buildkit 0.20.2 Welcome to the v0.20.2 release of buildkit! Please try out the release binaries and report any issues at https://github.com/moby/buildkit/issues. ##### Contributors - Akihiro Suda - Derek McGowan - Jonathan A. Sternberg ##### Changes - Fix possible UID overflow when setting user for container [#5844](https://redirect.github.com/moby/buildkit/issues/5844) GHSA-265r-hfxg-fhmg - update RootlessKit to v2.3.4 [#5825](https://redirect.github.com/moby/buildkit/issues/5825) ##### Dependency Changes - **github.com/containerd/containerd/v2** v2.0.3 -> v2.0.4 Previous release can be found at [v0.20.1](https://redirect.github.com/moby/buildkit/releases/tag/v0.20.1) ### [`v0.20.1`](https://redirect.github.com/moby/buildkit/releases/tag/v0.20.1) [Compare Source](https://redirect.github.com/moby/buildkit/compare/v0.20.0...v0.20.1) Welcome to the v0.20.1 release of buildkit! Please try out the release binaries and report any issues at https://github.com/moby/buildkit/issues. ##### Contributors - Tõnis Tiigi - Akihiro Suda - CrazyMax ##### Notable Changes - Builtin Dockerfile frontend has been updated to [v1.14.1](https://redirect.github.com/moby/buildkit/releases/tag/dockerfile%2F1.14.1) - Fix panic during CDI manager initialization. [#5769](https://redirect.github.com/moby/buildkit/issues/5769) [cncf-tags/container-device-interface#254](https://redirect.github.com/cncf-tags/container-device-interface/issues/254) - Fix gRPC message size when writing SBOMs. [#5798](https://redirect.github.com/moby/buildkit/issues/5798) [containerd/containerd#11457](https://redirect.github.com/containerd/containerd/issues/11457) - Fix possible panic with libc-bin emulation in QEMU v9.2.0. [#5808](https://redirect.github.com/moby/buildkit/issues/5808) - Update azblob client retries for GitHub Actions cache backend. [#5797](https://redirect.github.com/moby/buildkit/issues/5797) [tonistiigi/go-actions-cache#33](https://redirect.github.com/tonistiigi/go-actions-cache/issues/33) ##### Dependency Changes - **github.com/containerd/containerd/v2** v2.0.2 -> v2.0.3 - **github.com/tonistiigi/go-actions-cache** [`1a5174a`](https://redirect.github.com/moby/buildkit/commit/1a5174abd055) -> [`3e9a664`](https://redirect.github.com/moby/buildkit/commit/3e9a6642607f) - **tags.cncf.io/container-device-interface** v0.8.0 -> v0.8.1 Previous release can be found at [v0.20.0](https://redirect.github.com/moby/buildkit/releases/tag/v0.20.0) ### [`v0.20.0`](https://redirect.github.com/moby/buildkit/releases/tag/v0.20.0) [Compare Source](https://redirect.github.com/moby/buildkit/compare/v0.19.0...v0.20.0) Welcome to the v0.20.0 release of buildkit! Please try out the release binaries and report any issues at https://github.com/moby/buildkit/issues. ##### Contributors - CrazyMax - Tõnis Tiigi - Sebastiaan van Stijn - Jonathan A. Sternberg - Akihiro Suda - Anthony Nandaa - Shaun Thompson - Austin Vazquez - Bertrand Paquet - Brian Goff - Pranav Pandit ##### Notable Changes - Builtin Dockerfile frontend has been updated to [v1.14.0](https://redirect.github.com/moby/buildkit/releases/tag/dockerfile%2F1.14.0) - Github Actions cache backend has been updated to support v2 API. Github is expected to stop supporting V1 API from March 1st 2025. [#5720](https://redirect.github.com/moby/buildkit/issues/5720) [#5750](https://redirect.github.com/moby/buildkit/issues/5750) [#5754](https://redirect.github.com/moby/buildkit/issues/5754) - Support for CDI (Container Device Interface) devices has been added allowing builds to use GPUs and other defined devices. Build steps can now request devices to be injected into the container, if they are permitted to do so. In Dockerfile, devices are currently available in the `labs` channel. [#4056](https://redirect.github.com/moby/buildkit/issues/4056) [#5722](https://redirect.github.com/moby/buildkit/issues/5722) [#5726](https://redirect.github.com/moby/buildkit/issues/5726) [#5729](https://redirect.github.com/moby/buildkit/issues/5729) [#5742](https://redirect.github.com/moby/buildkit/issues/5742) - History record APIs now support server-side filters and limiting amount of records returned. [#5705](https://redirect.github.com/moby/buildkit/issues/5705) - Update Runc to v1.2.5. [#5741](https://redirect.github.com/moby/buildkit/issues/5741) - Embedded binfmt emulators in the release image have been updated to QEMU v9.2.0 [#5695](https://redirect.github.com/moby/buildkit/issues/5695) [#5736](https://redirect.github.com/moby/buildkit/issues/5736) - Fix possible errors from credentials expiration for long builds. [#5684](https://redirect.github.com/moby/buildkit/issues/5684) - Fix possible crash from S3 remote cache backend. [#5597](https://redirect.github.com/moby/buildkit/issues/5597) - Fix possible record leak in Bolt database. [#5692](https://redirect.github.com/moby/buildkit/issues/5692) - Fix invalid warning messages when running subrequests (e.g. check, outline) for a specific platform. [#5730](https://redirect.github.com/moby/buildkit/issues/5730) ##### Dependency Changes - **github.com/Azure/azure-sdk-for-go/sdk/azcore** v1.11.1 -> v1.16.0 - **github.com/Azure/azure-sdk-for-go/sdk/azidentity** v1.6.0 -> v1.8.0 - **github.com/Azure/azure-sdk-for-go/sdk/internal** v1.8.0 -> v1.10.0 - **github.com/Azure/azure-sdk-for-go/sdk/storage/azblob** v0.4.1 -> v1.5.0 - **github.com/AzureAD/microsoft-authentication-library-for-go** v1.2.2 -> v1.3.2 - **github.com/containerd/cgroups/v3** v3.0.3 -> v3.0.5 - **github.com/containerd/fuse-overlayfs-snapshotter/v2** v2.1.0 -> v2.1.1 - **github.com/containerd/go-cni** v1.1.11 -> v1.1.12 - **github.com/docker/cli** v27.5.0 -> v27.5.1 - **github.com/docker/docker** v27.5.0 -> v27.5.1 - **github.com/moby/term** v0.5.0 -> v0.5.2 - **github.com/package-url/packageurl-go** [`8907843`](https://redirect.github.com/moby/buildkit/commit/89078438f170) -> v0.1.1 - **github.com/petermattis/goid** [`4fcff4a`](https://redirect.github.com/moby/buildkit/commit/4fcff4a6cae7) ***new*** - **github.com/sasha-s/go-deadlock** v0.3.5 ***new*** - **github.com/tonistiigi/go-actions-cache** [`017636a`](https://redirect.github.com/moby/buildkit/commit/017636a73805) -> [`1a5174a`](https://redirect.github.com/moby/buildkit/commit/1a5174abd055) - **github.com/vishvananda/netns** v0.0.4 -> v0.0.5 - **golang.org/x/exp** [`701f63a`](https://redirect.github.com/moby/buildkit/commit/701f63a606c0) -> [`2d47ceb`](https://redirect.github.com/moby/buildkit/commit/2d47ceb2692f) - **golang.org/x/mod** v0.21.0 -> v0.22.0 - **golang.org/x/sys** v0.28.0 -> v0.29.0 - **google.golang.org/genproto/googleapis/api** [`5fefd90`](https://redirect.github.com/moby/buildkit/commit/5fefd90f89a9) -> [`324edc3`](https://redirect.github.com/moby/buildkit/commit/324edc3d5d38) - **google.golang.org/grpc** v1.68.1 -> v1.69.4 Previous release can be found at [v0.19.0](https://redirect.github.com/moby/buildkit/releases/tag/v0.19.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/SectorLabs/buildkit-ghcr-mirror).

klihub requested review from elezar and bart0sh February 22, 2025 15:09

klihub force-pushed the fixes/refresh-sigsegv-with-nil-watcher branch from be9b6f3 to 73b86d0 Compare February 22, 2025 15:22

klihub mentioned this pull request Feb 22, 2025

panic: runtime error: invalid memory address or nil pointer dereference moby/buildkit#5767

Closed

4 tasks

tonistiigi mentioned this pull request Feb 22, 2025

vendor: cdi v0.8.1 for panic fix moby/buildkit#5769

Merged

bart0sh reviewed Feb 23, 2025

View reviewed changes

pkg/cdi/cache_test.go Outdated Show resolved Hide resolved

bart0sh reviewed Feb 23, 2025

View reviewed changes

pkg/cdi/cache_test.go Outdated Show resolved Hide resolved

bart0sh reviewed Feb 23, 2025

View reviewed changes

pkg/cdi/cache_test.go Outdated Show resolved Hide resolved

elezar approved these changes Feb 24, 2025

View reviewed changes

klihub force-pushed the fixes/refresh-sigsegv-with-nil-watcher branch from 73b86d0 to ada455e Compare February 24, 2025 09:03

klihub added 2 commits February 24, 2025 11:48

pkg/cdi: add test case for EMFILE crash (avoidance).

ad4e8f8

Signed-off-by: Krisztian Litkey <[email protected]>

klihub force-pushed the fixes/refresh-sigsegv-with-nil-watcher branch from ada455e to f674bc0 Compare February 24, 2025 09:51

klihub requested a review from bart0sh February 24, 2025 09:54

pkg/cdi: add test case for post-EMFILE recovery.

1de2560

Test that the cache indeed recovers functionally if the process ever recovers from not being able to create new file descriptors. Signed-off-by: Krisztian Litkey <[email protected]>

klihub force-pushed the fixes/refresh-sigsegv-with-nil-watcher branch from f674bc0 to 1de2560 Compare February 24, 2025 09:57

bart0sh merged commit a582593 into cncf-tags:main Feb 24, 2025
8 checks passed

klihub deleted the fixes/refresh-sigsegv-with-nil-watcher branch February 24, 2025 10:24

klihub mentioned this pull request Feb 24, 2025

[release/0.8] don't crash in cache refresh/update with nil fsnotify watcher. #255

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: don't crash in cache refresh/update with nil fsnotify watcher. #254

fix: don't crash in cache refresh/update with nil fsnotify watcher. #254

Uh oh!

klihub commented Feb 22, 2025

Uh oh!

bart0sh Feb 23, 2025 •

edited

Loading

Uh oh!

elezar Feb 24, 2025

Uh oh!

klihub Feb 24, 2025

Uh oh!

klihub Feb 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elezar left a comment

Uh oh!

Uh oh!

Uh oh!

fix: don't crash in cache refresh/update with nil fsnotify watcher. #254

fix: don't crash in cache refresh/update with nil fsnotify watcher. #254

Uh oh!

Conversation

klihub commented Feb 22, 2025

Uh oh!

bart0sh Feb 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elezar Feb 24, 2025

Choose a reason for hiding this comment

Uh oh!

klihub Feb 24, 2025

Choose a reason for hiding this comment

Uh oh!

klihub Feb 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elezar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bart0sh Feb 23, 2025 •

edited

Loading